Re: IPT [PATCH] yay, autotools!

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Nov 28 2007 12:25, Patrick McHardy wrote:
>> > >  - I think we should move all manuals to libxt_*.man or perhaps
>> > >  even *.man, would reduce Makefile LOC.
>> > You mean for the ones where we have an IPv4 and IPv6 version, but
>> > no xtables extension? I'm not sure they're all similar ...
>> >
>> I mean libipt_unclean.man -> libxt_unclean.man. The source file
>> libipt_unclean.c will persist. As unclean only matches libipt_%
>> the manpage will only land in iptables.8, not ip6tables.8.
>
> Then whats the advantage? Similar to the kernel, I think we should
> only use xt_ for things that actually support more than one
> address family.

Well, just look at it:

        for ext in $(1); do \
                f="${srcdir}/libxt_$$ext.man"; \
                if [ -f "$$f" ]; then \
                        echo ".SS $$ext"; \
                        cat "$$f"; \
                        continue; \
                fi; \
                f="${srcdir}/libipt_$$ext.man"; \
                if [ -f "$$f" ]; then \
                        echo ".SS $$ext"; \
                        cat "$$f"; \
                        continue; \
                fi; \
                f="${srcdir}/libip6t_$$ext.man"; \
                if [ -f "$$f" ]; then \
                        echo ".SS $$ext"; \
                        cat "$$f"; \
                        continue; \
                fi; \
        done >$@;

could be reduced to 1/3 of its size.

>> BTW, libipq inside iptables seems to be totally unused, is it still needed?
>
> Yes, people are still using it and the nfnetlink_queue compat library
> is still nonfunctional.
>
but *iptables* itself does not use it, does it? in which case
libipq should probably move to its own tarball, that is what
I was proposing.
-
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux