Re: [PATCH] Fix make/compile error for iptables-1.4.0rc1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Sun, 25 Nov 2007 16:13:59 +0100

> Jesper Dangaard Brouer wrote:
> > Fixing a make/compile issue with iptables, release candidate 1.4.0rc1,
> > which has existed since SVN changeset 6920.  This patch adds ip_tables.h
> > and ip6_tables.h, and updates x_tables.h, taken from Linus'es git tree.
> > 
> > Changeset 6920 added the include file x_tables.h from kernel source, but
> > didn't add ip_tables.h and ip6_tables.h.
> > 
> > At some point (Tue Nov 14 19:48:48 2006, by Yasuyuki Kozakai) these
> > kernel headers where changed, which actually removes certain
> > depencencies from ip_tables.h and ip6_tables.h to x_tables.h.
> > 
> > If compiling will fail, with old kernel headers (ip_tables.h and
> > ip6_tables.h) available in systems include path, because they depend on
> > certaine defines in x_tables.h with is missing in the version in SVN.
> 
> 
> Applied, but I stripped the #ifdef __KERNEL__ sections first.
> Thanks Jesper.

Thanks Jesper and Patrick. That looks fine to me.

XT_SO_GET_REVISION_{MATCH,TARGET} in 2.6.18 was removed because of
conflicts on {get,set}sockopt number of IPv6 socket. I.e. ip_tables.h
you used on build included bug.

iptables.c only uses IPT_SO_GET_REVISION_* and they are defined in local
header include/iptables.h. I suspects that
/usr/include/linux/netfilter_ipv4/ip_tables.h re-defined
IPT_SO_GET_REVISION_* with XT_SO_GET_REVISION_* on your environment.

P.S. sorry for late reply. I was very busy for other work this several
months but I will be able to contribute to netfilter again from next month.

Regards,

-- Yasuyuki Kozakai

-
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux