Re: [NETFILTER 01/02]: nf_conntrack_tcp: fix connection reopening fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Thu, 18 Oct 2007, Patrick McHardy wrote:

Krzysztof Oledzki wrote:


On Thu, 18 Oct 2007, Patrick McHardy wrote:

[NETFILTER]: nf_conntrack_tcp: fix connection reopening fix

Setting the last_dir parameter was missing from the previous one.

This description is IMHO wrong. It should be as in previous, little incomplete (last_dir), patch:

"If one side aborts an established connection, the entry still lingers for
10s in conntrack for the late packets. Allow to open up the connection
again for the party which sent the RST packet."


The first patch was submitted seperately with a somewhat similar
description. This is just the incremental fix.

No, there are two independent fixes. The first one is already in the mainline (nf_conntrack_tcp: fix connection reopening) and it is OK:
  http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=17311393f969090ab060540bd9dbe7dc885a76d5

The second one had been incomplete:
 http://marc.info/?l=netfilter-devel&m=119214261727254&w=1
and it was recently fixed:
 http://marc.info/?l=netfilter-devel&m=119264302103523&w=1

So, this "Setting the last_dir parameter was missing from the previous one." comment applies to this patch:
 http://marc.info/?l=netfilter-devel&m=119214261727254&w=1

Best regards,

				Krzysztof Olędzki

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux