Re: libxt_TCPOPTSTRIP(iptables) 20071014

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Oct 14 2007 17:19, Krzysztof Oledzki wrote:
> On Sun, 14 Oct 2007, Jan Engelhardt wrote:
>
>> +static const struct tcp_optionmap tcp_optionmap[] = {
>> +	{"wscale",         "Window scale",         TCPOPT_WINDOW},
>> +	{"mss",            "Maximum Segment Size", TCPOPT_MAXSEG},
>> +	{"sack-permitted", "SACK permitted",       TCPOPT_SACK_PERMITTED},
>> +	{"sack",           "Selective ACK",        TCPOPT_SACK},
>> +	{"timestamp",      "Timestamp",            TCPOPT_TIMESTAMP},
>> +	{"md5",            "MD5 signature",        TCPOPT_MD5SIG},
>> +	{NULL},
>> +};
>
> Ahh, good. Thank you for considering my suggestions.
>
> Just cosmetic: what about making it up to
> http://www.iana.org/assignments/tcp-parameters:
>
> s/Window scale/Window Scale/
> s/SACK permitted/SACK Permitted/
> s/MD5 signature/MD5 Signature/

I think there is a limit to pedantry :)
-
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux