Re: Addrtype match: renaming functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Laszlo Attila Toth wrote:
> Hello,
> 
> The function names in libipt_addrtype.c makes debugging hard, also I renamed them
> prefixed by 'addrtype_'.


Applied, thanks Laszlo.


> @@ -191,11 +191,11 @@
>  	.version 	= IPTABLES_VERSION,
>  	.size 		= IPT_ALIGN(sizeof(struct ipt_addrtype_info)),
>  	.userspacesize 	= IPT_ALIGN(sizeof(struct ipt_addrtype_info)),
> -	.help 		= &help,
> -	.parse 		= &parse,
> -	.final_check 	= &final_check,
> -	.print 		= &print,
> -	.save 		= &save,
> +	.help 		= &addrtype_help,
> +	.parse 		= &addrtype_parse,
> +	.final_check 	= &addrtype_final_check,
> +	.print 		= &addrtype_print,
> +	.save 		= &addrtype_save,


Just a hint for future patches: the & is not required, I personally
prefer to omit them. Not worth sending another patch though.
-
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux