2010/6/13 Reimar D?ffinger <Reimar.Doeffinger at gmx.de>: > On Sun, Jun 13, 2010 at 05:32:42PM +0200, Giorgio wrote: >> Ok, I made a new checkout, applied the patch and compiled mplayer. Now >> the error is gone from the output of mplayer, but the problem is still >> there. I made a video so you can see for yourself: > > You could try this (or in general randomly comment out things in that function > until it works, it must be something in that function that causes it (I think): > Index: libvo/x11_common.c > =================================================================== > --- libvo/x11_common.c ?(revision 31384) > +++ libvo/x11_common.c ?(working copy) > @@ -1153,7 +1155,7 @@ > ?final: > ? if (vo_gc != None) > ? ? XFreeGC(mDisplay, vo_gc); > - ?vo_gc = XCreateGC(mDisplay, vo_window, GCForeground, &xgcv); > +// ?vo_gc = XCreateGC(mDisplay, vo_window, GCForeground, &xgcv); > ? XSync(mDisplay, False); > ? vo_mouse_autohide = 1; > ?} I tried this but made mplayer exit without playing anything. >> It's interesting that if I press 'f' to go in fullscreen mode, I see >> the video, but the osd information is showed twice and the last digit >> has another digit under it. > > I guess it is most likely a driver bug... Ok, I fixed this one enabling "double buffering" like this: http://imagebin.ca/view/7DLnaR.html . Also, I noticed that I needed this even before (r31376), so the last modifications didn't introduce this problem. >> It would be nice if someone else could test this too, maybe it's just >> my system, but again r31380 works fine. But I understand that gmplayer >> is basically unsupported nowadays. Thank you anyway. > > Well, if only gmplayer was the issue I wouldn't care much, however > gmplayer now uses the interface that all MPlayer GUIs should use, > so if gmplayer has this issue, other GUIs might have the same. Finally, I did many tests, but this simple modification solves the issue for me: Index: gui/interface.c =================================================================== --- gui/interface.c (revision 31381) +++ gui/interface.c (working copy) @@ -552,7 +552,6 @@ guiIntfStruct.MovieHeight=vo_dheight; if (guiWinID>=0) wsMoveWindow( &appMPlayer.mainWindow,0,0, vo_dheight); - WinID = appMPlayer.subWindow.WindowID; } break; #ifdef CONFIG_DVDREAD I don't get the error if I apply this patch, and the video frames are displayed correctly now, both in window and fullscreen mode. Thanks. Giorgio Vazzana
