On Thu, 16 Oct 2008, Jason Garrett-Glaser wrote: > On Thu, Oct 16, 2008 at 5:40 AM, Keith Lawson <lawsonk at lawson-tech.com> wrote: >> Hello, >> >> I downloaded the SVN copy last night and it wouldn't build due to a small >> typo in libavcodec/libx264.c. The Gentoo guys have already supplied a >> patch here: >> >> http://bugs.gentoo.org/attachment.cgi?id=167513&action=edit > > Perhaps the Gentoo guys should actually pay a few seconds of attention > to development so that they know why the error occurs, rather than > immediately declaring it a "typo" and trying to patch it downstream > without telling anyone? Oh, wait, then they wouldn't be Gentoo. > Sorry, I'm not an mplayer developer OR a Gentoo developer. I just used that change to get mplayer to build on my system and assumed the Gentoo bug report was accurate. Being new to the mplayer source I assumed this mailing list would be the place for help. Considering all the recent discussion about building from SVN rather than using the tarball release I don't think this type of mistake is unreasonable. Keith.