Subject: [merged] hpet-remove-useless-check-if-fixmem32-is-null.patch removed from -mm tree
To: tomas.winkler@xxxxxxxxx,clemens@xxxxxxxxxx,msw@xxxxxxxxxx,prarit@xxxxxxxxxx,rdunlap@xxxxxxxxxxxxx,mm-commits@xxxxxxxxxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Mon, 30 Sep 2013 15:22:12 -0700
The patch titled
Subject: drivers/char/hpet.c: remove useless check if fixmem32 is NULL
has been removed from the -mm tree. Its filename was
hpet-remove-useless-check-if-fixmem32-is-null.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
From: Tomas Winkler <tomas.winkler@xxxxxxxxx>
Subject: drivers/char/hpet.c: remove useless check if fixmem32 is NULL
fixmem32 is assigned to address of res->data member so the address is
always valid
Actually since we are not checking for res != NULL static analyzing is
complaining about referencing the pointer and consequent check for null.
The code snippet looks confusing also for human eyes.
Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
Signed-off-by: Clemens Ladisch <clemens@xxxxxxxxxx>
Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Cc: Matt Wilson <msw@xxxxxxxxxx>
Cc: Prarit Bhargava <prarit@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/char/hpet.c | 2 --
1 file changed, 2 deletions(-)
diff -puN drivers/char/hpet.c~hpet-remove-useless-check-if-fixmem32-is-null drivers/char/hpet.c
--- a/drivers/char/hpet.c~hpet-remove-useless-check-if-fixmem32-is-null
+++ a/drivers/char/hpet.c
@@ -971,8 +971,6 @@ static acpi_status hpet_resources(struct
struct acpi_resource_fixed_memory32 *fixmem32;
fixmem32 = &res->data.fixed_memory32;
- if (!fixmem32)
- return AE_NO_MEMORY;
hdp->hd_phys_address = fixmem32->address;
hdp->hd_address = ioremap(fixmem32->address,
_
Patches currently in -mm which might be from tomas.winkler@xxxxxxxxx are
hpet-allow-user-controlled-mmap-for-user-processes.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
