Subject: [merged] pidns-kill-the-unnecessary-clone_newpid-in-copy_process.patch removed from -mm tree
To: oleg@xxxxxxxxxx,ebiederm@xxxxxxxxxxxx,luto@xxxxxxxxxxxxxx,walters@xxxxxxxxxx,mm-commits@xxxxxxxxxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Thu, 12 Sep 2013 12:41:11 -0700
The patch titled
Subject: pidns: kill the unnecessary CLONE_NEWPID in copy_process()
has been removed from the -mm tree. Its filename was
pidns-kill-the-unnecessary-clone_newpid-in-copy_process.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
From: Oleg Nesterov <oleg@xxxxxxxxxx>
Subject: pidns: kill the unnecessary CLONE_NEWPID in copy_process()
8382fcac ("pidns: Outlaw thread creation after unshare(CLONE_NEWPID)")
nacks CLONE_NEWPID if the forking process unshared pid_ns. This is
correct but unnecessary, copy_pid_ns() does the same check.
Remove the CLONE_NEWPID check to cleanup the code and prepare for the next
change.
Test-case:
static int child(void *arg)
{
return 0;
}
static char stack[16 * 1024];
int main(void)
{
pid_t pid;
assert(unshare(CLONE_NEWUSER | CLONE_NEWPID) == 0);
pid = clone(child, stack + sizeof(stack) / 2,
CLONE_NEWPID | SIGCHLD, NULL);
assert(pid < 0 && errno == EINVAL);
return 0;
}
clone(CLONE_NEWPID) correctly fails with or without this change.
Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
Acked-by: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
Cc: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
Cc: Colin Walters <walters@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
kernel/fork.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff -puN kernel/fork.c~pidns-kill-the-unnecessary-clone_newpid-in-copy_process kernel/fork.c
--- a/kernel/fork.c~pidns-kill-the-unnecessary-clone_newpid-in-copy_process
+++ a/kernel/fork.c
@@ -1177,9 +1177,8 @@ static struct task_struct *copy_process(
* allow it to share a thread group or signal handlers with the
* forking task.
*/
- if ((clone_flags & (CLONE_SIGHAND | CLONE_NEWPID)) &&
- (task_active_pid_ns(current) !=
- current->nsproxy->pid_ns_for_children))
+ if ((clone_flags & CLONE_SIGHAND) && (task_active_pid_ns(current) !=
+ current->nsproxy->pid_ns_for_children))
return ERR_PTR(-EINVAL);
retval = security_task_create(clone_flags);
_
Patches currently in -mm which might be from oleg@xxxxxxxxxx are
origin.patch
anon_inodefs-forbid-open-via-proc.patch
autofs4-allow-autofs-to-work-outside-the-initial-pid-namespace.patch
autofs4-translate-pids-to-the-right-namespace-for-the-daemon.patch
signals-eventpoll-set-saved_sigmask-at-the-start.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
