Subject: [to-be-updated] makefile-enable-werror=implicit-int-and-werror=strict-prototypes-by-default.patch removed from -mm tree To: slyfox@xxxxxxxxxx,mmarek@xxxxxxx,mm-commits@xxxxxxxxxxxxxxx From: akpm@xxxxxxxxxxxxxxxxxxxx Date: Fri, 23 Aug 2013 16:07:39 -0700 The patch titled Subject: Makefile: enable -Werror=implicit-int and -Werror=strict-prototypes by default has been removed from the -mm tree. Its filename was makefile-enable-werror=implicit-int-and-werror=strict-prototypes-by-default.patch This patch was dropped because an updated version will be merged ------------------------------------------------------ From: Sergei Trofimovich <slyfox@xxxxxxxxxx> Subject: Makefile: enable -Werror=implicit-int and -Werror=strict-prototypes by default A common error type found in forward-ported/backported patches is missing headers. One recent example (files and function names are mangled): void foo(){} EXPORT_SYMBOL(foo); gave only warning foo.c:12345678:5: warning: function declaration isn't a prototype [-Wstrict-prototypes] void foo(){} ^ foo.c:12345679:5: warning: data definition has no type or storage class [enabled by default] EXPORT_SYMBOL(foo); foo.c:12345679:5: warning: type defaults to 'int' in declaration of 'EXORT_SYMBOL' [-Werror=implicit-int] Now it's a fata error. Tested on x86_64 allyesconfig. Signed-off-by: Sergei Trofimovich <slyfox@xxxxxxxxxx> Cc: Michal Marek <mmarek@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- Makefile | 5 +++++ 1 file changed, 5 insertions(+) diff -puN Makefile~makefile-enable-werror=implicit-int-and-werror=strict-prototypes-by-default Makefile --- a/Makefile~makefile-enable-werror=implicit-int-and-werror=strict-prototypes-by-default +++ a/Makefile @@ -374,6 +374,11 @@ KBUILD_CFLAGS := -Wall -Wundef -Wstric -Werror-implicit-function-declaration \ -Wno-format-security \ -fno-delete-null-pointer-checks + +# not universally available, but nice to have ones +KBUILD_CFLAGS += $(call cc-option,-Werror=implicit-int) \ + $(call cc-option,-Werror=strict-prototypes) + KBUILD_AFLAGS_KERNEL := KBUILD_CFLAGS_KERNEL := KBUILD_AFLAGS := -D__ASSEMBLY__ _ Patches currently in -mm which might be from slyfox@xxxxxxxxxx are cleanup-add-forward-declarations-for-inplace-syscall-wrappers.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html