Subject: [nacked] ipc-mq-do-not-validate-queue-attributes-default-ceiling-value-if-the-user-passed-attr==null.patch removed from -mm tree
To: sasikanth.v19@xxxxxxxxx,dledford@xxxxxxxxxx,jlayton@xxxxxxxxxx,manfred@xxxxxxxxxxxxxxxx,vdavydov@xxxxxxxxxxxxx,mm-commits@xxxxxxxxxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Thu, 15 Aug 2013 13:02:52 -0700
The patch titled
Subject: ipc/mq: do not validate queue attributes default/ceiling value if the user passed attr==NULL
has been removed from the -mm tree. Its filename was
ipc-mq-do-not-validate-queue-attributes-default-ceiling-value-if-the-user-passed-attr==null.patch
This patch was dropped because it was nacked
------------------------------------------------------
From: Sasikantha Babu <sasikanth.v19@xxxxxxxxx>
Subject: ipc/mq: do not validate queue attributes default/ceiling value if the user passed attr==NULL
The kernel should not validate queue attributes default/ceiling value
while creating a mqueue, if user passed attr as NULL. Otherwise in the
worst case if the validation fails then sys_mq_open returns
-EINVAL/-EOVERFLOW which will leave the user clueless about the reason for
the failure.
Signed-off-by: Sasikantha Babu <sasikanth.v19@xxxxxxxxx>
Cc: Jeff Layton <jlayton@xxxxxxxxxx>
Cc: Vladimir Davydov <vdavydov@xxxxxxxxxxxxx>
Cc: Sasikantha Babu <sasikanth.v19@xxxxxxxxx>
Cc: Doug Ledford <dledford@xxxxxxxxxx>
Cc: Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
ipc/mqueue.c | 10 ----------
1 file changed, 10 deletions(-)
diff -puN ipc/mqueue.c~ipc-mq-do-not-validate-queue-attributes-default-ceiling-value-if-the-user-passed-attr==null ipc/mqueue.c
--- a/ipc/mqueue.c~ipc-mq-do-not-validate-queue-attributes-default-ceiling-value-if-the-user-passed-attr==null
+++ a/ipc/mqueue.c
@@ -741,16 +741,6 @@ static struct file *do_create(struct ipc
return ERR_PTR(ret);
/* store for use during create */
path->dentry->d_fsdata = attr;
- } else {
- struct mq_attr def_attr;
-
- def_attr.mq_maxmsg = min(ipc_ns->mq_msg_max,
- ipc_ns->mq_msg_default);
- def_attr.mq_msgsize = min(ipc_ns->mq_msgsize_max,
- ipc_ns->mq_msgsize_default);
- ret = mq_attr_ok(ipc_ns, &def_attr);
- if (ret)
- return ERR_PTR(ret);
}
mode &= ~current_umask();
_
Patches currently in -mm which might be from sasikanth.v19@xxxxxxxxx are
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
