Subject: + ipc-mq-do-not-validate-queue-attributes-default-ceiling-value-if-the-user-passed-attr==null.patch added to -mm tree
To: sasikanth.v19@xxxxxxxxx,dledford@xxxxxxxxxx,jlayton@xxxxxxxxxx,manfred@xxxxxxxxxxxxxxxx,vdavydov@xxxxxxxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Wed, 14 Aug 2013 15:45:42 -0700
The patch titled
Subject: ipc/mq: do not validate queue attributes default/ceiling value if the user passed attr==NULL
has been added to the -mm tree. Its filename is
ipc-mq-do-not-validate-queue-attributes-default-ceiling-value-if-the-user-passed-attr==null.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/ipc-mq-do-not-validate-queue-attributes-default-ceiling-value-if-the-user-passed-attr==null.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/ipc-mq-do-not-validate-queue-attributes-default-ceiling-value-if-the-user-passed-attr==null.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Sasikantha Babu <sasikanth.v19@xxxxxxxxx>
Subject: ipc/mq: do not validate queue attributes default/ceiling value if the user passed attr==NULL
The kernel should not validate queue attributes default/ceiling value
while creating a mqueue, if user passed attr as NULL. Otherwise in the
worst case if the validation fails then sys_mq_open returns
-EINVAL/-EOVERFLOW which will leave the user clueless about the reason for
the failure.
Signed-off-by: Sasikantha Babu <sasikanth.v19@xxxxxxxxx>
Cc: Jeff Layton <jlayton@xxxxxxxxxx>
Cc: Vladimir Davydov <vdavydov@xxxxxxxxxxxxx>
Cc: Sasikantha Babu <sasikanth.v19@xxxxxxxxx>
Cc: Doug Ledford <dledford@xxxxxxxxxx>
Cc: Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
ipc/mqueue.c | 10 ----------
1 file changed, 10 deletions(-)
diff -puN ipc/mqueue.c~ipc-mq-do-not-validate-queue-attributes-default-ceiling-value-if-the-user-passed-attr==null ipc/mqueue.c
--- a/ipc/mqueue.c~ipc-mq-do-not-validate-queue-attributes-default-ceiling-value-if-the-user-passed-attr==null
+++ a/ipc/mqueue.c
@@ -741,16 +741,6 @@ static struct file *do_create(struct ipc
return ERR_PTR(ret);
/* store for use during create */
path->dentry->d_fsdata = attr;
- } else {
- struct mq_attr def_attr;
-
- def_attr.mq_maxmsg = min(ipc_ns->mq_msg_max,
- ipc_ns->mq_msg_default);
- def_attr.mq_msgsize = min(ipc_ns->mq_msgsize_max,
- ipc_ns->mq_msgsize_default);
- ret = mq_attr_ok(ipc_ns, &def_attr);
- if (ret)
- return ERR_PTR(ret);
}
mode &= ~current_umask();
_
Patches currently in -mm which might be from sasikanth.v19@xxxxxxxxx are
ipc-mq-do-not-validate-queue-attributes-default-ceiling-value-if-the-user-passed-attr==null.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
