Subject: + upc-use-local_irq_saverestore-in-smp_call_function_single.patch added to -mm tree
To: david.daney@xxxxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Mon, 05 Aug 2013 15:47:28 -0700
The patch titled
Subject: up.c: use local_irq_{save,restore}() in smp_call_function_single.
has been added to the -mm tree. Its filename is
upc-use-local_irq_saverestore-in-smp_call_function_single.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/upc-use-local_irq_saverestore-in-smp_call_function_single.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/upc-use-local_irq_saverestore-in-smp_call_function_single.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: David Daney <david.daney@xxxxxxxxxx>
Subject: up.c: use local_irq_{save,restore}() in smp_call_function_single.
The SMP version of this function doesn't unconditionally enable irqs, so
neither should this !SMP version. There are no know problems caused by
this, but we make the change for consistency's sake.
Signed-off-by: David Daney <david.daney@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
kernel/up.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff -puN kernel/up.c~upc-use-local_irq_saverestore-in-smp_call_function_single kernel/up.c
--- a/kernel/up.c~upc-use-local_irq_saverestore-in-smp_call_function_single
+++ a/kernel/up.c
@@ -10,11 +10,13 @@
int smp_call_function_single(int cpu, void (*func) (void *info), void *info,
int wait)
{
+ unsigned long flags;
+
WARN_ON(cpu != 0);
- local_irq_disable();
- (func)(info);
- local_irq_enable();
+ local_irq_save(flags);
+ func(info);
+ local_irq_restore(flags);
return 0;
}
_
Patches currently in -mm which might be from david.daney@xxxxxxxxxx are
revert-include-linux-smph-on_each_cpu-switch-back-to-a-macro.patch
smp-quit-unconditionally-enabling-irq-in-on_each_cpu_mask-and-on_each_cpu_cond.patch
upc-use-local_irq_saverestore-in-smp_call_function_single.patch
smph-move-smp-version-of-on_each_cpu-out-of-line.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
