Subject: + firmware-dmi_scan-drop-obsolete-comment.patch added to -mm tree
To: jdelvare@xxxxxxx,joe@xxxxxxxxxxx,mingo@xxxxxxxxxx,yinghai@xxxxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Wed, 10 Jul 2013 14:34:41 -0700
The patch titled
Subject: firmware/dmi_scan: drop obsolete comment
has been added to the -mm tree. Its filename is
firmware-dmi_scan-drop-obsolete-comment.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/firmware-dmi_scan-drop-obsolete-comment.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/firmware-dmi_scan-drop-obsolete-comment.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Jean Delvare <jdelvare@xxxxxxx>
Subject: firmware/dmi_scan: drop obsolete comment
This comment predates the introduction of early_ioremap. Since then the
missing calls to dmi_iounmap have been added by Ingo and Yinghai in
commits 0d64484f7ea1 ("x86: fix DMI ioremap leak") and 3212bff370c2f
("x86: left over fix for leak of early_ioremp in dmi_scan") . That was
over 5 years ago so it is about time to drop this now misleading comment.
Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxxxxx>
Cc: Yinghai Lu <yinghai@xxxxxxxxxx>
Cc: Joe Perches <joe@xxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/firmware/dmi_scan.c | 5 -----
1 file changed, 5 deletions(-)
diff -puN drivers/firmware/dmi_scan.c~firmware-dmi_scan-drop-obsolete-comment drivers/firmware/dmi_scan.c
--- a/drivers/firmware/dmi_scan.c~firmware-dmi_scan-drop-obsolete-comment
+++ a/drivers/firmware/dmi_scan.c
@@ -504,11 +504,6 @@ void __init dmi_scan_machine(void)
}
}
else {
- /*
- * no iounmap() for that ioremap(); it would be a no-op, but
- * it's so early in setup that sucker gets confused into doing
- * what it shouldn't if we actually call it.
- */
p = dmi_ioremap(0xF0000, 0x10000);
if (p == NULL)
goto error;
_
Patches currently in -mm which might be from jdelvare@xxxxxxx are
origin.patch
linux-next.patch
dmi_scan-add-comments-on-dmi_present-and-the-loop-in-dmi_scan_machine.patch
firmware-dmi_scan-drop-obsolete-comment.patch
firmware-dmi_scan-fix-most-checkpatch-errors-and-warnings.patch
firmware-dmi_scan-constify-strings.patch
firmware-dmi_scan-drop-oom-messages.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
