Subject: [-] drivers-usb-gadget-amd5536udcc-avoid-calling-dma_pool_create-with-null-dev.patch removed from -mm tree
To: xi.wang@xxxxxxxxx,balbi@xxxxxx,greg@xxxxxxxxx,mm-commits@xxxxxxxxxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Wed, 10 Jul 2013 13:25:05 -0700
The patch titled
Subject: drivers/usb/gadget/amd5536udc.c: avoid calling dma_pool_create() with NULL dev
has been removed from the -mm tree. Its filename was
drivers-usb-gadget-amd5536udcc-avoid-calling-dma_pool_create-with-null-dev.patch
This patch was dropped because it has gone stale
------------------------------------------------------
From: Xi Wang <xi.wang@xxxxxxxxx>
Subject: drivers/usb/gadget/amd5536udc.c: avoid calling dma_pool_create() with NULL dev
Calling dma_pool_create() with dev==NULL will oops on a NUMA machine.
Rather than changing dma_pool_create() we wish to disallow passing
dev==NULL. This requires fixing up the small number of drivers which are
passing in dev==NULL.
Use &dev->pdev->dev instead of NULL.
Signed-off-by: Xi Wang <xi.wang@xxxxxxxxx>
Cc: Felipe Balbi <balbi@xxxxxx>
Cc: Greg KH <greg@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/usb/gadget/amd5536udc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN drivers/usb/gadget/amd5536udc.c~drivers-usb-gadget-amd5536udcc-avoid-calling-dma_pool_create-with-null-dev drivers/usb/gadget/amd5536udc.c
--- a/drivers/usb/gadget/amd5536udc.c~drivers-usb-gadget-amd5536udcc-avoid-calling-dma_pool_create-with-null-dev
+++ a/drivers/usb/gadget/amd5536udc.c
@@ -3099,7 +3099,7 @@ static int init_dma_pools(struct udc *de
}
/* DMA setup */
- dev->data_requests = dma_pool_create("data_requests", NULL,
+ dev->data_requests = dma_pool_create("data_requests", &dev->pdev->dev,
sizeof(struct udc_data_dma), 0, 0);
if (!dev->data_requests) {
DBG(dev, "can't get request data pool\n");
@@ -3111,7 +3111,7 @@ static int init_dma_pools(struct udc *de
dev->ep[UDC_EP0IN_IX].dma = &dev->regs->ctl;
/* dma desc for setup data */
- dev->stp_requests = dma_pool_create("setup requests", NULL,
+ dev->stp_requests = dma_pool_create("setup requests", &dev->pdev->dev,
sizeof(struct udc_stp_dma), 0, 0);
if (!dev->stp_requests) {
DBG(dev, "can't get stp request pool\n");
_
Patches currently in -mm which might be from xi.wang@xxxxxxxxx are
mm-dmapoolc-fix-null-dev-in-dma_pool_create.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
