Subject: + aoe-perform-i-o-completions-in-parallel-v2.patch added to -mm tree
To: ecashin@xxxxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Tue, 02 Jul 2013 19:54:59 -0700
The patch titled
Subject: aoe-perform-i-o-completions-in-parallel-v2
has been added to the -mm tree. Its filename is
aoe-perform-i-o-completions-in-parallel-v2.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Ed Cashin <ecashin@xxxxxxxxxx>
Subject: aoe-perform-i-o-completions-in-parallel-v2
Signed-off-by: Ed Cashin <ecashin@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/block/aoe/aoecmd.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff -puN drivers/block/aoe/aoecmd.c~aoe-perform-i-o-completions-in-parallel-v2 drivers/block/aoe/aoecmd.c
--- a/drivers/block/aoe/aoecmd.c~aoe-perform-i-o-completions-in-parallel-v2
+++ a/drivers/block/aoe/aoecmd.c
@@ -35,9 +35,12 @@ module_param(aoe_maxout, int, 0644);
MODULE_PARM_DESC(aoe_maxout,
"Only aoe_maxout outstanding packets for every MAC on eX.Y.");
-/* The number of online cpus in the system,
- * this dictates the number of ktio threads
- * which will be spawned.
+/* The number of online cpus during module initialization gives us a
+ * convenient heuristic cap on the parallelism used for ktio threads
+ * doing I/O completion. It is not important that the cap equal the
+ * actual number of running CPUs at any given time, but because of CPU
+ * hotplug, we take care to use ncpus instead of using
+ * num_online_cpus() after module initialization.
*/
static int ncpus;
@@ -1792,10 +1795,6 @@ aoecmd_init(void)
return -ENOMEM;
empty_page = virt_to_page(p);
-
- /* The number of ktio threads to be spawned are governed by the
- * number of online cpus available in the system.
- */
ncpus = num_online_cpus();
iocq = kcalloc(ncpus, sizeof(struct iocq_ktio), GFP_KERNEL);
_
Patches currently in -mm which might be from ecashin@xxxxxxxxxx are
aoe-perform-i-o-completions-in-parallel.patch
aoe-perform-i-o-completions-in-parallel-v2.patch
aoe-update-copyright-date.patch
aoe-update-internal-version-number-to-v83.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
