Subject: + rtc-omap-restore-back-hard-code-wakeup-support.patch added to -mm tree
To: gururaja.hebbar@xxxxxx,a.zummo@xxxxxxxxxxxx,khilman@xxxxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Tue, 02 Jul 2013 16:04:56 -0700
The patch titled
Subject: rtc: omap: restore back (hard-code) wakeup support
has been added to the -mm tree. Its filename is
rtc-omap-restore-back-hard-code-wakeup-support.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/rtc-omap-restore-back-hard-code-wakeup-support.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/rtc-omap-restore-back-hard-code-wakeup-support.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Hebbar Gururaja <gururaja.hebbar@xxxxxx>
Subject: rtc: omap: restore back (hard-code) wakeup support
rtc-omap driver modules is used both by OMAP1/2, Davinci SoC platforms.
However, rtc wake support on OMAP1 is broken. Hence the
device_init_wakeup() was removed from rtc-omap driver and moved to
platform board files that supported it (DA850/OMAP-L138). [1]
However, recently [2] it was suggested that driver should always do a
device_init_wakeup(dev, true). Platforms that don't want/need
wakeup support can disable it from userspace via:
echo disabled > /sys/devices/.../power/wakeup
Also, with the new DT boot-up, board file doesn't exist and hence there
is no way to have device wakeup support rtc.
The fix for above issues, is to hard code device_init_wakeup() inside
driver and let platforms that don't need this, handle it through the
sysfs power entry.
[1]
https://patchwork.kernel.org/patch/136731/
[2]
http://www.mail-archive.com/davinci-linux-open-source@linux.
davincidsp.com/msg26077.html
Signed-off-by: Hebbar Gururaja <gururaja.hebbar@xxxxxx>
Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>
Acked-by: Kevin Hilman <khilman@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/rtc/rtc-omap.c | 2 ++
1 file changed, 2 insertions(+)
diff -puN drivers/rtc/rtc-omap.c~rtc-omap-restore-back-hard-code-wakeup-support drivers/rtc/rtc-omap.c
--- a/drivers/rtc/rtc-omap.c~rtc-omap-restore-back-hard-code-wakeup-support
+++ a/drivers/rtc/rtc-omap.c
@@ -421,6 +421,8 @@ static int __init omap_rtc_probe(struct
* is write-only, and always reads as zero...)
*/
+ device_init_wakeup(&pdev->dev, true);
+
if (new_ctrl & (u8) OMAP_RTC_CTRL_SPLIT)
pr_info("%s: split power mode\n", pdev->name);
_
Patches currently in -mm which might be from gururaja.hebbar@xxxxxx are
linux-next.patch
rtc-omap-restore-back-hard-code-wakeup-support.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
