Subject: + ocfs2-remove-unecessary-variable-needs_checkpoint.patch added to -mm tree
To: rgoldwyn@xxxxxxxxx,jeff.liu@xxxxxxxxxx,jlbec@xxxxxxxxxxxx,mfasheh@xxxxxxxx,rgoldwyn@xxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Mon, 10 Jun 2013 16:36:35 -0700
The patch titled
Subject: ocfs2: remove unecessary variable needs_checkpoint
has been added to the -mm tree. Its filename is
ocfs2-remove-unecessary-variable-needs_checkpoint.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Goldwyn Rodrigues <rgoldwyn@xxxxxxxxx>
Subject: ocfs2: remove unecessary variable needs_checkpoint
Code cleanup: needs_checkpoint is assigned to but never used. Delete the
variable.
Signed-off-by: Goldwyn Rodrigues <rgoldwyn@xxxxxxxx>
Cc: Jeff Liu <jeff.liu@xxxxxxxxxx>
Cc: Joel Becker <jlbec@xxxxxxxxxxxx>
Cc: Mark Fasheh <mfasheh@xxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/ocfs2/journal.h | 1 -
fs/ocfs2/ocfs2.h | 1 -
fs/ocfs2/super.c | 6 ++----
3 files changed, 2 insertions(+), 6 deletions(-)
diff -puN fs/ocfs2/journal.h~ocfs2-remove-unecessary-variable-needs_checkpoint fs/ocfs2/journal.h
--- a/fs/ocfs2/journal.h~ocfs2-remove-unecessary-variable-needs_checkpoint
+++ a/fs/ocfs2/journal.h
@@ -200,7 +200,6 @@ void ocfs2_complete_quota_recovery(struc
static inline void ocfs2_start_checkpoint(struct ocfs2_super *osb)
{
- atomic_set(&osb->needs_checkpoint, 1);
wake_up(&osb->checkpoint_event);
}
diff -puN fs/ocfs2/ocfs2.h~ocfs2-remove-unecessary-variable-needs_checkpoint fs/ocfs2/ocfs2.h
--- a/fs/ocfs2/ocfs2.h~ocfs2-remove-unecessary-variable-needs_checkpoint
+++ a/fs/ocfs2/ocfs2.h
@@ -347,7 +347,6 @@ struct ocfs2_super
struct task_struct *recovery_thread_task;
int disable_recovery;
wait_queue_head_t checkpoint_event;
- atomic_t needs_checkpoint;
struct ocfs2_journal *journal;
unsigned long osb_commit_interval;
diff -puN fs/ocfs2/super.c~ocfs2-remove-unecessary-variable-needs_checkpoint fs/ocfs2/super.c
--- a/fs/ocfs2/super.c~ocfs2-remove-unecessary-variable-needs_checkpoint
+++ a/fs/ocfs2/super.c
@@ -286,10 +286,9 @@ static int ocfs2_osb_dump(struct ocfs2_s
spin_unlock(&osb->osb_lock);
out += snprintf(buf + out, len - out,
- "%10s => Pid: %d Interval: %lu Needs: %d\n", "Commit",
+ "%10s => Pid: %d Interval: %lu\n", "Commit",
(osb->commit_task ? task_pid_nr(osb->commit_task) : -1),
- osb->osb_commit_interval,
- atomic_read(&osb->needs_checkpoint));
+ osb->osb_commit_interval);
out += snprintf(buf + out, len - out,
"%10s => State: %d TxnId: %lu NumTxns: %d\n",
@@ -2154,7 +2153,6 @@ static int ocfs2_initialize_super(struct
}
init_waitqueue_head(&osb->checkpoint_event);
- atomic_set(&osb->needs_checkpoint, 0);
osb->s_atime_quantum = OCFS2_DEFAULT_ATIME_QUANTUM;
_
Patches currently in -mm which might be from rgoldwyn@xxxxxxxxx are
fs-ocfs2-nameic-remove-unecessary-error-when-removing-non-empty-directory.patch
ocfs2-remove-unecessary-variable-needs_checkpoint.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
