Subject: + kprobes-handle-empty-invalid-input-to-debugfs-enabled-file.patch added to -mm tree
To: minipli@xxxxxxxxxxxxxx,ananth@xxxxxxxxxx,anil.s.keshavamurthy@xxxxxxxxx,davem@xxxxxxxxxxxxx,masami.hiramatsu.pt@xxxxxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Mon, 03 Jun 2013 15:58:29 -0700
The patch titled
Subject: kprobes: handle empty/invalid input to debugfs "enabled" file
has been added to the -mm tree. Its filename is
kprobes-handle-empty-invalid-input-to-debugfs-enabled-file.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Mathias Krause <minipli@xxxxxxxxxxxxxx>
Subject: kprobes: handle empty/invalid input to debugfs "enabled" file
When writing invalid input to 'debug/kprobes/enabled' it'll silently be
ignored. Even worse, when writing an empty string to this file, the
outcome is purely random as the switch statement will make its decision
based on the value of an uninitialized stack variable.
Fix this by handling invalid/empty input as error returning -EINVAL.
Signed-off-by: Mathias Krause <minipli@xxxxxxxxxxxxxx>
Cc: Ananth N Mavinakayanahalli <ananth@xxxxxxxxxx>
Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@xxxxxxxxx>
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
kernel/kprobes.c | 3 +++
1 file changed, 3 insertions(+)
diff -puN kernel/kprobes.c~kprobes-handle-empty-invalid-input-to-debugfs-enabled-file kernel/kprobes.c
--- a/kernel/kprobes.c~kprobes-handle-empty-invalid-input-to-debugfs-enabled-file
+++ a/kernel/kprobes.c
@@ -2322,6 +2322,7 @@ static ssize_t write_enabled_file_bool(s
if (copy_from_user(buf, user_buf, buf_size))
return -EFAULT;
+ buf[buf_size] = '\0';
switch (buf[0]) {
case 'y':
case 'Y':
@@ -2333,6 +2334,8 @@ static ssize_t write_enabled_file_bool(s
case '0':
disarm_all_kprobes();
break;
+ default:
+ return -EINVAL;
}
return count;
_
Patches currently in -mm which might be from minipli@xxxxxxxxxxxxxx are
kprobes-handle-empty-invalid-input-to-debugfs-enabled-file.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
