The patch titled Subject: rtc: rtc-pcap: remove unnecessary platform_set_drvdata() has been added to the -mm tree. Its filename is rtc-rtc-pcap-remove-unnecessary-platform_set_drvdata.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Jingoo Han <jg1.han@xxxxxxxxxxx> Subject: rtc: rtc-pcap: remove unnecessary platform_set_drvdata() The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d063100 ("device-core: Ensure drvdata = NULL when no driver is bound"). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/rtc/rtc-pcap.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff -puN drivers/rtc/rtc-pcap.c~rtc-rtc-pcap-remove-unnecessary-platform_set_drvdata drivers/rtc/rtc-pcap.c --- a/drivers/rtc/rtc-pcap.c~rtc-rtc-pcap-remove-unnecessary-platform_set_drvdata +++ a/drivers/rtc/rtc-pcap.c @@ -156,10 +156,8 @@ static int __init pcap_rtc_probe(struct pcap_rtc->rtc = devm_rtc_device_register(&pdev->dev, "pcap", &pcap_rtc_ops, THIS_MODULE); - if (IS_ERR(pcap_rtc->rtc)) { - err = PTR_ERR(pcap_rtc->rtc); - goto fail; - } + if (IS_ERR(pcap_rtc->rtc)) + return PTR_ERR(pcap_rtc->rtc); timer_irq = pcap_to_irq(pcap_rtc->pcap, PCAP_IRQ_1HZ); alarm_irq = pcap_to_irq(pcap_rtc->pcap, PCAP_IRQ_TODA); @@ -167,17 +165,14 @@ static int __init pcap_rtc_probe(struct err = devm_request_irq(&pdev->dev, timer_irq, pcap_rtc_irq, 0, "RTC Timer", pcap_rtc); if (err) - goto fail; + return err; err = devm_request_irq(&pdev->dev, alarm_irq, pcap_rtc_irq, 0, "RTC Alarm", pcap_rtc); if (err) - goto fail; + return err; return 0; -fail: - platform_set_drvdata(pdev, NULL); - return err; } static int __exit pcap_rtc_remove(struct platform_device *pdev) _ Patches currently in -mm which might be from jg1.han@xxxxxxxxxxx are origin.patch linux-next.patch backlight-atmel-pwm-bl-remove-unnecessary-platform_set_drvdata.patch backlight-ep93xx-remove-unnecessary-platform_set_drvdata.patch backlight-lp8788-remove-unnecessary-platform_set_drvdata.patch backlight-pcf50633-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-88pm80x-remove-unnecessary-platform_set_drvdata.patch drivers-rtc-rtc-v3020c-remove-redundant-goto.patch drivers-rtc-interfacec-fix-checkpatch-errors.patch drivers-rtc-rtc-at32ap700xc-fix-checkpatch-error.patch drivers-rtc-rtc-at91rm9200c-include-linux-uaccessh.patch drivers-rtc-rtc-cmosc-fix-whitespace-related-errors.patch drivers-rtc-rtc-davincic-fix-whitespace-warning.patch drivers-rtc-rtc-ds1305c-add-missing-braces-around-sizeof.patch drivers-rtc-rtc-ds1374c-fix-spacing-related-issues.patch drivers-rtc-rtc-ds1511c-fix-issues-related-to-spaces-and-braces.patch drivers-rtc-rtc-ds3234c-fix-whitespace-issue.patch drivers-rtc-rtc-fm3130c-fix-whitespace-related-issue.patch drivers-rtc-rtc-m41t80c-fix-spacing-related-issue.patch drivers-rtc-rtc-max6902c-remove-unwanted-spaces.patch drivers-rtc-rtc-max77686c-remove-space-before-semicolon.patch drivers-rtc-rtc-max8997c-remove-space-before-semicolon.patch drivers-rtc-rtc-mpc5121c-remove-space-before-tab.patch drivers-rtc-rtc-msm6242c-use-pr_warn.patch drivers-rtc-rtc-mxcc-fix-checkpatch-error.patch drivers-rtc-rtc-omapc-include-linux-ioh-instead-of-asm-ioh.patch drivers-rtc-rtc-pcf2123c-remove-space-before-tabs.patch drivers-rtc-rtc-pcf8583c-move-assignment-outside-if-condition.patch drivers-rtc-rtc-rs5c313c-include-linux-ioh-instead-of-asm-ioh.patch drivers-rtc-rtc-rs5c313c-fix-spacing-related-issues.patch drivers-rtc-rtc-v3020c-fix-spacing-issues.patch drivers-rtc-rtc-vr41xxc-fix-spacing-issues.patch drivers-rtc-rtc-x1205c-fix-checkpatch-issues.patch rtc-rtc-88pm860x-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-ab3100-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-ab8500-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-at32ap700x-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-at91rm9200-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-at91sam9-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-au1xxx-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-bfin-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-bq4802-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-coh901331-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-da9052-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-da9055-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-davinci-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-dm355evm-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-ds1302-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-ep93xx-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-jz4740-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-lp8788-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-lpc32xx-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-ls1x-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-m48t59-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-max8925-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-max8998-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-mc13xxx-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-msm6242-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-mxc-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-nuc900-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-pcap-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-pm8xxx-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-s3c-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-sa1100-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-sh-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-spear-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-stmp3xxx-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-twl-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-vr41xx-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-vt8500-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-m48t86-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-puv3-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-rp5c01-remove-unnecessary-platform_set_drvdata.patch rtc-rtc-tile-remove-unnecessary-platform_set_drvdata.patch drivers-rtc-rtc-pxac-use-devm_-apis.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html