The patch titled Subject: checkpatch: add Suggested-by as a standard signature has been added to the -mm tree. Its filename is checkpatch-add-suggested-by-as-a-standard-signature.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Mugunthan V N <mugunthanvnm@xxxxxx> Subject: checkpatch: add Suggested-by as a standard signature As people started using Suggested-by as standard signature, adding "Suggested-by" to the standard signature so that checkpatch won't generate warning when Suggested-by is used in patch signature Signed-off-by: Mugunthan V N <mugunthanvnm@xxxxxx> Cc: Andy Whitcroft <apw@xxxxxxxxxxxxx> Cc: Joe Perches <joe@xxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- Documentation/SubmittingPatches | 9 ++++++++- scripts/checkpatch.pl | 1 + 2 files changed, 9 insertions(+), 1 deletion(-) diff -puN Documentation/SubmittingPatches~checkpatch-add-suggested-by-as-a-standard-signature Documentation/SubmittingPatches --- a/Documentation/SubmittingPatches~checkpatch-add-suggested-by-as-a-standard-signature +++ a/Documentation/SubmittingPatches @@ -420,7 +420,7 @@ person it names. This tag documents tha have been included in the discussion -14) Using Reported-by:, Tested-by: and Reviewed-by: +14) Using Reported-by:, Tested-by:, Reviewed-by: and Suggested-by: If this patch fixes a problem reported by somebody else, consider adding a Reported-by: tag to credit the reporter for their contribution. Please @@ -468,6 +468,13 @@ done on the patch. Reviewed-by: tags, w understand the subject area and to perform thorough reviews, will normally increase the likelihood of your patch getting into the kernel. +A Suggested-by: tag indicates that the patch idea is suggested by the person +named and ensures credit to the person for the idea. Please note that this +tag should not be added without the reporter's permission, especially if the +idea was not posted in a public forum. That said, if we diligently credit our +idea reporters, they will, hopefully, be inspired to help us again in the +future. + 15) The canonical patch format diff -puN scripts/checkpatch.pl~checkpatch-add-suggested-by-as-a-standard-signature scripts/checkpatch.pl --- a/scripts/checkpatch.pl~checkpatch-add-suggested-by-as-a-standard-signature +++ a/scripts/checkpatch.pl @@ -281,6 +281,7 @@ our $signature_tags = qr{(?xi: Tested-by:| Reviewed-by:| Reported-by:| + Suggested-by:| To:| Cc: )}; _ Patches currently in -mm which might be from mugunthanvnm@xxxxxx are linux-next.patch checkpatch-add-suggested-by-as-a-standard-signature.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html