The patch titled Subject: rtc: rtc-nuc900: use devm_*() functions has been added to the -mm tree. Its filename is rtc-rtc-nuc900-use-devm_-functions.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Jingoo Han <jg1.han@xxxxxxxxxxx> Subject: rtc: rtc-nuc900: use devm_*() functions Use devm_*() functions to make cleanup paths simpler. Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/rtc/rtc-nuc900.c | 53 +++++++------------------------------ 1 file changed, 11 insertions(+), 42 deletions(-) diff -puN drivers/rtc/rtc-nuc900.c~rtc-rtc-nuc900-use-devm_-functions drivers/rtc/rtc-nuc900.c --- a/drivers/rtc/rtc-nuc900.c~rtc-rtc-nuc900-use-devm_-functions +++ a/drivers/rtc/rtc-nuc900.c @@ -226,9 +226,9 @@ static int __init nuc900_rtc_probe(struc { struct resource *res; struct nuc900_rtc *nuc900_rtc; - int err = 0; - nuc900_rtc = kzalloc(sizeof(struct nuc900_rtc), GFP_KERNEL); + nuc900_rtc = devm_kzalloc(&pdev->dev, sizeof(struct nuc900_rtc), + GFP_KERNEL); if (!nuc900_rtc) { dev_err(&pdev->dev, "kzalloc nuc900_rtc failed\n"); return -ENOMEM; @@ -236,68 +236,37 @@ static int __init nuc900_rtc_probe(struc res = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!res) { dev_err(&pdev->dev, "platform_get_resource failed\n"); - err = -ENXIO; - goto fail1; + return -ENXIO; } - if (!request_mem_region(res->start, resource_size(res), - pdev->name)) { - dev_err(&pdev->dev, "request_mem_region failed\n"); - err = -EBUSY; - goto fail1; - } - - nuc900_rtc->rtc_reg = ioremap(res->start, resource_size(res)); - if (!nuc900_rtc->rtc_reg) { - dev_err(&pdev->dev, "ioremap rtc_reg failed\n"); - err = -ENOMEM; - goto fail2; - } + nuc900_rtc->rtc_reg = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(nuc900_rtc->rtc_reg)) + return PTR_ERR(nuc900_rtc->rtc_reg); platform_set_drvdata(pdev, nuc900_rtc); - nuc900_rtc->rtcdev = rtc_device_register(pdev->name, &pdev->dev, + nuc900_rtc->rtcdev = devm_rtc_device_register(&pdev->dev, pdev->name, &nuc900_rtc_ops, THIS_MODULE); if (IS_ERR(nuc900_rtc->rtcdev)) { dev_err(&pdev->dev, "rtc device register failed\n"); - err = PTR_ERR(nuc900_rtc->rtcdev); - goto fail3; + return PTR_ERR(nuc900_rtc->rtcdev); } __raw_writel(__raw_readl(nuc900_rtc->rtc_reg + REG_RTC_TSSR) | MODE24, nuc900_rtc->rtc_reg + REG_RTC_TSSR); nuc900_rtc->irq_num = platform_get_irq(pdev, 0); - if (request_irq(nuc900_rtc->irq_num, nuc900_rtc_interrupt, - 0, "nuc900rtc", nuc900_rtc)) { + if (devm_request_irq(&pdev->dev, nuc900_rtc->irq_num, + nuc900_rtc_interrupt, 0, "nuc900rtc", nuc900_rtc)) { dev_err(&pdev->dev, "NUC900 RTC request irq failed\n"); - err = -EBUSY; - goto fail4; + return -EBUSY; } return 0; - -fail4: rtc_device_unregister(nuc900_rtc->rtcdev); -fail3: iounmap(nuc900_rtc->rtc_reg); -fail2: release_mem_region(res->start, resource_size(res)); -fail1: kfree(nuc900_rtc); - return err; } static int __exit nuc900_rtc_remove(struct platform_device *pdev) { - struct nuc900_rtc *nuc900_rtc = platform_get_drvdata(pdev); - struct resource *res; - - free_irq(nuc900_rtc->irq_num, nuc900_rtc); - rtc_device_unregister(nuc900_rtc->rtcdev); - iounmap(nuc900_rtc->rtc_reg); - - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - release_mem_region(res->start, resource_size(res)); - - kfree(nuc900_rtc); - platform_set_drvdata(pdev, NULL); return 0; _ Patches currently in -mm which might be from jg1.han@xxxxxxxxxxx are linux-next.patch drivers-block-mg_diskc-add-config_pm_sleep-to-suspend-resume-functions.patch drivers-video-backlight-ams369fg06c-convert-ams369fg06-to-dev_pm_ops.patch drivers-video-backlight-ams369fg06c-convert-ams369fg06-to-dev_pm_ops-fix.patch backlight-platform_lcd-remove-unnecessary-ifdefs.patch backlight-ep93xx_bl-remove-incorrect-__init-annotation.patch drivers-video-backlight-atmel-pwm-blc-use-module_platform_driver_probe.patch drivers-video-backlight-atmel-pwm-blc-add-__init-annotation.patch drivers-video-backlight-lp855x_blc-fix-compiler-warning-in-lp855x_probe.patch drivers-video-backlight-jornada720_c-use-dev_err-dev_info-instead-of-pr_err-pr_info.patch drivers-video-backlight-omap1_blc-use-dev_info-instead-of-pr_info.patch drivers-video-backlight-generic_blc-use-dev_info-instead-of-pr_info.patch backlight-adp8870-add-missing-braces.patch drivers-video-backlight-l4f00242t03c-check-return-value-of-regulator_enable.patch drivers-video-backlight-l4f00242t03c-check-return-value-of-regulator_enable-fix.patch backlight-ld9040-convert-ld9040-to-dev_pm_ops.patch backlight-lms501kf03-convert-lms501kf03-to-dev_pm_ops.patch backlight-s6e63m0-convert-s6e63m0-to-dev_pm_ops.patch backlight-adp5520-convert-adp5520_bl-to-dev_pm_ops.patch backlight-adp8860-convert-adp8860-to-dev_pm_ops.patch backlight-adp8870-convert-adp8870-to-dev_pm_ops.patch backlight-corgi_lcd-convert-corgi_lcd-to-dev_pm_ops.patch backlight-ep93xx-convert-ep93xx-to-dev_pm_ops.patch backlight-hp680_bl-convert-hp680bl-to-dev_pm_ops.patch backlight-kb3886_bl-convert-kb3886bl-to-dev_pm_ops.patch backlight-lm3533_bl-convert-lm3533_bl-to-dev_pm_ops.patch backlight-locomolcd-convert-locomolcd-to-dev_pm_ops.patch backlight-ltv350qv-convert-ltv350qv-to-dev_pm_ops.patch backlight-tdo24m-convert-tdo24m-to-dev_pm_ops.patch drivers-video-backlight-kconfig-fix-typo-mach_sam9ek-three-times.patch drivers-video-backlight-adp5520_blc-fix-compiler-warning-in-adp5520_show.patch video-backlight-add-ili922x-lcd-driver.patch backlight-da903x_bl-use-bl_core_suspendresume-option.patch backlight-lp855x-use-page_size-for-the-sysfs-read-operation.patch drivers-video-backlight-adp8860_blc-fix-error-return-code-in-adp8860_led_probe.patch drivers-video-backlight-adp8870_blc-fix-error-return-code-in-adp8870_led_probe.patch drivers-video-backlight-as3711_blc-add-of-support.patch backlight-ili9320-use-spi_set_drvdata.patch backlight-ili922x-use-spi_set_drvdata.patch rtc-rtc-mv-add-__init-annotation.patch rtc-rtc-davinci-add-__exit-annotation.patch rtc-rtc-ds1302-add-__exit-annotation.patch rtc-rtc-imxdi-add-__init-__exit-annotation.patch rtc-rtc-nuc900-add-__init-__exit-annotation.patch rtc-rtc-pcap-add-__init-__exit-annotation.patch rtc-rtc-tegra-add-__init-__exit-annotation.patch rtc-add-devm_rtc_device_registerunregister.patch rtc-max77686-use-module_platform_driver.patch rtc-max77686-add-missing-module-author-name.patch rtc-max77686-use-devm_kzalloc.patch rtc-max77686-fix-indentation-of-bit-definitions.patch rtc-max77686-use-dev_info-dev_emerg-instead-of-pr_info-pr_emerg.patch rtc-rtc-v3020-use-gpio_request_array.patch rtc-use-struct-device-as-the-first-argument-for-devm_rtc_device_register.patch rtc-rtc-ab3100-use-module_platform_driver_probe.patch rtc-rtc-at32ap700x-use-module_platform_driver_probe.patch rtc-rtc-at91rm9200-use-module_platform_driver_probe.patch rtc-rtc-au1xxx-use-module_platform_driver_probe.patch rtc-rtc-coh901331-use-module_platform_driver_probe.patch rtc-rtc-davinci-use-module_platform_driver_probe.patch rtc-rtc-ds1302-use-module_platform_driver_probe.patch rtc-rtc-efi-use-module_platform_driver_probe.patch rtc-rtc-generic-use-module_platform_driver_probe.patch rtc-rtc-imxdi-use-module_platform_driver_probe.patch rtc-rtc-mc13xxx-use-module_platform_driver_probe.patch rtc-rtc-msm6242-use-module_platform_driver_probe.patch rtc-rtc-mv-use-module_platform_driver_probe.patch rtc-rtc-nuc900-use-module_platform_driver_probe.patch rtc-rtc-omap-use-module_platform_driver_probe.patch rtc-rtc-pcap-use-module_platform_driver_probe.patch rtc-rtc-ps3-use-module_platform_driver_probe.patch rtc-rtc-pxa-use-module_platform_driver_probe.patch rtc-rtc-rp5c01-use-module_platform_driver_probe.patch rtc-rtc-sh-use-module_platform_driver_probe.patch rtc-rtc-starfire-use-module_platform_driver_probe.patch rtc-rtc-sun4v-use-module_platform_driver_probe.patch rtc-rtc-tegra-use-module_platform_driver_probe.patch rtc-rtc-tx4939-use-module_platform_driver_probe.patch rtc-rtc-88pm80x-use-devm_rtc_device_register.patch rtc-rtc-coh90133-use-devm_rtc_device_register.patch rtc-rtc-da9052-use-devm_rtc_device_register.patch rtc-rtc-da9055-use-devm_rtc_device_register.patch rtc-rtc-davinci-use-devm_rtc_device_register.patch rtc-rtc-ds1511-use-devm_rtc_device_register.patch rtc-rtc-ds1553-use-devm_rtc_device_register.patch rtc-rtc-ds1742-use-devm_rtc_device_register.patch rtc-rtc-ep93xx-use-devm_rtc_device_register.patch rtc-rtc-imxdi-use-devm_rtc_device_register.patch rtc-rtc-lp8788-use-devm_rtc_device_register.patch rtc-rtc-lpc32xx-use-devm_rtc_device_register.patch rtc-rtc-max77686-use-devm_rtc_device_register.patch rtc-rtc-max8907-use-devm_rtc_device_register.patch rtc-rtc-max8997-use-devm_rtc_device_register.patch rtc-rtc-mv-use-devm_rtc_device_register.patch rtc-rtc-mxc-use-devm_rtc_device_register.patch rtc-rtc-palmas-use-devm_rtc_device_register.patch rtc-rtc-pcf8523-use-devm_rtc_device_register.patch rtc-rtc-s3c-use-devm_rtc_device_register.patch rtc-rtc-snvs-use-devm_rtc_device_register.patch rtc-rtc-spear-use-devm_rtc_device_register.patch rtc-rtc-stk17ta8-use-devm_rtc_device_register.patch rtc-rtc-tps6586x-use-devm_rtc_device_register.patch rtc-rtc-tps65910-use-devm_rtc_device_register.patch rtc-rtc-tps80031-use-devm_rtc_device_register.patch rtc-rtc-tx4939-use-devm_rtc_device_register.patch rtc-rtc-vt8500-use-devm_rtc_device_register.patch rtc-rtc-wm831x-use-devm_rtc_device_register.patch rtc-tegra-protect-suspend-resume-callbacks-with-config_pm_sleep.patch rtc-tegra-use-struct-dev_pm_ops-for-power-management.patch rtc-tegra-set-irq-name-as-device-name.patch rtc-tegra-use-managed-rtc_device_register.patch rtc-rtc-s3c-convert-s3c_rtc-to-dev_pm_ops.patch rtc-rtc-ds1307-use-dev_dbg-instead-of-pr_debug.patch rtc-rtc-fm3130-use-dev_dbg-instead-of-pr_debug.patch rtc-rtc-ab3100-use-devm_rtc_device_register.patch rtc-rtc-au1xxx-use-devm_rtc_device_register.patch rtc-rtc-bq32k-use-devm_rtc_device_register.patch rtc-rtc-dm355evm-use-devm_rtc_device_register.patch rtc-rtc-ds1302-use-devm_rtc_device_register.patch rtc-rtc-ds1672-use-devm_rtc_device_register.patch rtc-rtc-ds3234-use-devm_rtc_device_register.patch rtc-rtc-efi-use-devm_rtc_device_register.patch rtc-rtc-em3027-use-devm_rtc_device_register.patch rtc-rtc-generic-use-devm_rtc_device_register.patch rtc-hid-sensor-time-use-devm_rtc_device_register.patch rtc-rtc-ls1x-use-devm_rtc_device_register.patch rtc-rtc-m41t93-use-devm_rtc_device_register.patch rtc-rtc-m41t94-use-devm_rtc_device_register.patch rtc-rtc-m48t86-use-devm_rtc_device_register.patch rtc-rtc-max6900-use-devm_rtc_device_register.patch rtc-rtc-max6902-use-devm_rtc_device_register.patch rtc-rtc-ps3-use-devm_rtc_device_register.patch rtc-rtc-r9701-use-devm_rtc_device_register.patch rtc-rtc-rc5t583-use-devm_rtc_device_register.patch rtc-rtc-rs5c313-use-devm_rtc_device_register.patch rtc-rtc-rv3029c2-use-devm_rtc_device_register.patch rtc-rtc-rx4581-use-devm_rtc_device_register.patch rtc-rtc-rx8581-use-devm_rtc_device_register.patch rtc-rtc-starfire-use-devm_rtc_device_register.patch rtc-rtc-sun4v-use-devm_rtc_device_register.patch rtc-rtc-test-use-devm_rtc_device_register.patch rtc-rtc-tile-use-devm_rtc_device_register.patch rtc-rtc-wm8350-use-devm_rtc_device_register.patch rtc-rtc-x1205-use-devm_rtc_device_register.patch rtc-rtc-at91rm9200-switch-to-using-simple_dev_pm_ops.patch rtc-rtc-mxc-switch-to-using-simple_dev_pm_ops.patch rtc-rtc-pxa-switch-to-using-simple_dev_pm_ops.patch rtc-rtc-rc5t583-switch-to-using-simple_dev_pm_ops.patch rtc-rtc-sa1100-switch-to-using-simple_dev_pm_ops.patch rtc-rtc-sh-switch-to-using-simple_dev_pm_ops.patch rtc-rtc-wm8350-switch-to-using-simple_dev_pm_ops.patch rtc-rtc-tps6586x-switch-to-using-simple_dev_pm_ops.patch rtc-rtc-tps65910-switch-to-using-simple_dev_pm_ops.patch rtc-rtc-tps80031-switch-to-using-simple_dev_pm_ops.patch rtc-omap-update-to-devm_-api.patch drivers-rtc-rtc-ds1374c-add-config_pm_sleep-to-suspend-resume-functions.patch drivers-rtc-rtc-88pm80xc-add-config_pm_sleep-to-suspend-resume-functions.patch drivers-rtc-rtc-tps6586xc-remove-incorrect-use-of-rtc_device_unregister.patch drivers-rtc-rtc-tps65910c-fix-incorrect-return-value-on-error.patch drivers-rtc-rtc-max8997c-fix-incorrect-return-value-on-error.patch drivers-rtc-rtc-max77686c-fix-incorrect-return-value-on-error.patch drivers-rtc-rtc-max8907c-remove-redundant-code.patch rtc-rtc-rx4581-use-spi_set_drvdata.patch rtc-rtc-m41t94-use-spi_set_drvdata.patch rtc-rtc-r9701-use-spi_set_drvdata.patch rtc-rtc-ds3234-use-spi_set_drvdata.patch rtc-rtc-ds1390-use-spi_set_drvdata.patch rtc-rtc-m41t93-use-spi_set_drvdata.patch rtc-rtc-max6902-use-spi_set_drvdata.patch drivers-rtc-rtc-s3cc-use-clk_prepare_enable-and-clk_disable_unprepare.patch drivers-rtc-rtc-88pm860xc-use-devm_-apis.patch drivers-rtc-rtc-at32ap700xc-use-devm_-apis.patch drivers-rtc-rtc-ds1305c-use-devm_-apis.patch drivers-rtc-rtc-ds1374c-use-devm_-apis.patch drivers-rtc-rtc-ds3232c-use-devm_-apis.patch drivers-rtc-rtc-m48t35c-use-devm_-apis.patch drivers-rtc-rtc-max8925c-use-devm_-apis.patch drivers-rtc-rtc-pxac-use-devm_-apis.patch rtc-rtc-ab8500-use-devm_-functions.patch rtc-rtc-at91sam9-use-devm_-functions.patch rtc-rtc-bfin-use-devm_-functions.patch rtc-rtc-bq4802-use-devm_-functions.patch rtc-rtc-ds1216-use-devm_-functions.patch rtc-rtc-ds1286-use-devm_-functions.patch rtc-rtc-ds1390-use-devm_-functions.patch rtc-rtc-ds2404-use-devm_-functions.patch rtc-rtc-fm3130-use-devm_-functions.patch rtc-rtc-isl12022-use-devm_-functions.patch rtc-rtc-m41t80-use-devm_-functions.patch rtc-rtc-max8998-use-devm_-functions.patch rtc-rtc-mc13xxx-use-devm_-functions.patch rtc-rtc-msm6242-use-devm_-functions.patch rtc-rtc-nuc900-use-devm_-functions.patch rtc-rtc-pcap-use-devm_-functions.patch rtc-rtc-pcf2123-use-devm_-functions.patch rtc-rtc-pcf50633-use-devm_-functions.patch rtc-rtc-pcf8563-use-devm_-functions.patch rtc-rtc-pcf8583-use-devm_-functions.patch rtc-rtc-rp5c01-use-devm_-functions.patch rtc-rtc-rs5c348-use-devm_-functions.patch rtc-rtc-rs5c372-use-devm_-functions.patch rtc-rtc-s35390a-use-devm_-functions.patch rtc-rtc-sa1100-use-devm_-functions.patch rtc-rtc-stmp3xxx-use-devm_-functions.patch rtc-rtc-v3020-use-devm_-functions.patch memstick-r592-make-r592_pm_ops-static.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html