The patch titled
Subject: drivers/rtc/rtc-ds1307.c: change sysfs function pointer assignment
has been added to the -mm tree. Its filename is
drivers-rtc-rtc-ds1307c-change-sysfs-function-pointer-assignment.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx>
Subject: drivers/rtc/rtc-ds1307.c: change sysfs function pointer assignment
The current usage of commas instead of semicolons is not wrong, but
affects the readability of the code.
Also, the code would break, if someone puts something between those two
assignments.
Signed-off-by: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx>
Cc: Austin Boyle <Austin.Boyle@xxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/rtc/rtc-ds1307.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN drivers/rtc/rtc-ds1307.c~drivers-rtc-rtc-ds1307c-change-sysfs-function-pointer-assignment drivers/rtc/rtc-ds1307.c
--- a/drivers/rtc/rtc-ds1307.c~drivers-rtc-rtc-ds1307c-change-sysfs-function-pointer-assignment
+++ a/drivers/rtc/rtc-ds1307.c
@@ -908,8 +908,8 @@ read_rtc:
ds1307->nvram->attr.name = "nvram";
ds1307->nvram->attr.mode = S_IRUGO | S_IWUSR;
sysfs_bin_attr_init(ds1307->nvram);
- ds1307->nvram->read = ds1307_nvram_read,
- ds1307->nvram->write = ds1307_nvram_write,
+ ds1307->nvram->read = ds1307_nvram_read;
+ ds1307->nvram->write = ds1307_nvram_write;
ds1307->nvram->size = chip->nvram_size;
ds1307->nvram_offset = chip->nvram_offset;
err = sysfs_create_bin_file(&client->dev.kobj, ds1307->nvram);
_
Patches currently in -mm which might be from s.trumtrar@xxxxxxxxxxxxxx are
linux-next.patch
drivers-rtc-rtc-ds1307c-change-sysfs-function-pointer-assignment.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
