The patch titled
Subject: drivers/rtc/rtc-max8907.c: remove redundant code
has been added to the -mm tree. Its filename is
drivers-rtc-rtc-max8907c-remove-redundant-code.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
Subject: drivers/rtc/rtc-max8907.c: remove redundant code
Remove unnecessary goto statements to simplify the code.
devm_request_threaded_irq returns 0 upon success, hence explicit return 0
is not necessary.
Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
Cc: Chiwoong Byun <woong.byun@xxxxxxxxxxx>
Cc: Jonghwa Lee <jonghwa3.lee@xxxxxxxxxxx>
Cc: Laxman dewangan <ldewangan@xxxxxxxxxx>
Cc: Venu Byravarasu <vbyravarasu@xxxxxxxxxx>
Cc: Jingoo Han <jg1.han@xxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/rtc/rtc-max8907.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff -puN drivers/rtc/rtc-max8907.c~drivers-rtc-rtc-max8907c-remove-redundant-code drivers/rtc/rtc-max8907.c
--- a/drivers/rtc/rtc-max8907.c~drivers-rtc-rtc-max8907c-remove-redundant-code
+++ a/drivers/rtc/rtc-max8907.c
@@ -200,23 +200,16 @@ static int max8907_rtc_probe(struct plat
rtc->irq = regmap_irq_get_virq(max8907->irqc_rtc,
MAX8907_IRQ_RTC_ALARM0);
- if (rtc->irq < 0) {
- ret = rtc->irq;
- goto err_unregister;
- }
+ if (rtc->irq < 0)
+ return rtc->irq;
ret = devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL,
max8907_irq_handler,
IRQF_ONESHOT, "max8907-alarm0", rtc);
- if (ret < 0) {
+ if (ret < 0)
dev_err(&pdev->dev, "Failed to request IRQ%d: %d\n",
rtc->irq, ret);
- goto err_unregister;
- }
- return 0;
-
-err_unregister:
return ret;
}
_
Patches currently in -mm which might be from sachin.kamat@xxxxxxxxxx are
origin.patch
linux-next.patch
drivers-video-exynos-exynos_mipi_dsic-convert-to-devm_ioremap_resource.patch
drivers-rtc-rtc-tps6586xc-remove-incorrect-use-of-rtc_device_unregister.patch
drivers-rtc-rtc-tps65910c-fix-incorrect-return-value-on-error.patch
drivers-rtc-rtc-max8997c-fix-incorrect-return-value-on-error.patch
drivers-rtc-rtc-max77686c-fix-incorrect-return-value-on-error.patch
drivers-rtc-rtc-max8907c-remove-redundant-code.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
