The patch titled Subject: kernel/watchdog.c: add comments to explain watchdog_disabled variable has been added to the -mm tree. Its filename is kernel-watchdogc-add-comments-to-explain-watchdog_disabled-variable.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: anish kumar <anish198519851985@xxxxxxxxx> Subject: kernel/watchdog.c: add comments to explain watchdog_disabled variable This watchdog_disabled flag is a bit cryptic. However it's usefulness is multifold. Uses are: 1. Check if smpboot_register_percpu_thread function passed. 2. Makes sure that user enables and disables the watchdog in sequence i.e. enable watchdog->disable watchdog->enable watchdog Unlike enable watchdog->enable watchdog which is wrong. [dzickus@xxxxxxxxxx: small text cleanups] Signed-off-by: anish kumar <anish198519851985@xxxxxxxxx> Signed-off-by: Don Zickus <dzickus@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- kernel/watchdog.c | 5 +++++ 1 file changed, 5 insertions(+) diff -puN kernel/watchdog.c~kernel-watchdogc-add-comments-to-explain-watchdog_disabled-variable kernel/watchdog.c --- a/kernel/watchdog.c~kernel-watchdogc-add-comments-to-explain-watchdog_disabled-variable +++ a/kernel/watchdog.c @@ -521,6 +521,11 @@ int proc_dowatchdog(struct ctl_table *ta return ret; set_sample_period(); + /* + * Watchdog threads shouldn't be enabled if they are + * disabled. The 'watchdog_disabled' variable check in + * watchdog_*_all_cpus() function takes care of this. + */ if (watchdog_enabled && watchdog_thresh) watchdog_enable_all_cpus(); else _ Patches currently in -mm which might be from anish198519851985@xxxxxxxxx are kernel-watchdogc-add-comments-to-explain-watchdog_disabled-variable.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html