The patch titled Subject: drivers/video/backlight/adp8870_bl.c: add missing braces has been added to the -mm tree. Its filename is backlight-adp8870-add-missing-braces.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Jingoo Han <jg1.han@xxxxxxxxxxx> Subject: drivers/video/backlight/adp8870_bl.c: add missing braces Add missing braces to include error message. The error message is related to the return value for sysfs_create_group(). However, sysfs_create_group() is called when pdata->en_ambl_sens is not zero. Thus, the checking return value should be included in the if statement. Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/video/backlight/adp8870_bl.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff -puN drivers/video/backlight/adp8870_bl.c~backlight-adp8870-add-missing-braces drivers/video/backlight/adp8870_bl.c --- a/drivers/video/backlight/adp8870_bl.c~backlight-adp8870-add-missing-braces +++ a/drivers/video/backlight/adp8870_bl.c @@ -895,13 +895,13 @@ static int adp8870_probe(struct i2c_clie data->bl = bl; - if (pdata->en_ambl_sens) + if (pdata->en_ambl_sens) { ret = sysfs_create_group(&bl->dev.kobj, &adp8870_bl_attr_group); - - if (ret) { - dev_err(&client->dev, "failed to register sysfs\n"); - goto out1; + if (ret) { + dev_err(&client->dev, "failed to register sysfs\n"); + goto out1; + } } ret = adp8870_bl_setup(bl); _ Patches currently in -mm which might be from jg1.han@xxxxxxxxxxx are linux-next.patch drivers-video-backlight-ams369fg06c-convert-ams369fg06-to-dev_pm_ops.patch drivers-video-backlight-ams369fg06c-convert-ams369fg06-to-dev_pm_ops-fix.patch backlight-platform_lcd-remove-unnecessary-ifdefs.patch backlight-ep93xx_bl-remove-incorrect-__init-annotation.patch drivers-video-backlight-atmel-pwm-blc-use-module_platform_driver_probe.patch drivers-video-backlight-atmel-pwm-blc-add-__init-annotation.patch drivers-video-backlight-lp855x_blc-fix-compiler-warning-in-lp855x_probe.patch drivers-video-backlight-jornada720_c-use-dev_err-dev_info-instead-of-pr_err-pr_info.patch drivers-video-backlight-omap1_blc-use-dev_info-instead-of-pr_info.patch drivers-video-backlight-generic_blc-use-dev_info-instead-of-pr_info.patch backlight-adp8870-add-missing-braces.patch rtc-rtc-mv-add-__init-annotation.patch rtc-rtc-davinci-add-__exit-annotation.patch rtc-rtc-ds1302-add-__exit-annotation.patch rtc-rtc-imxdi-add-__init-__exit-annotation.patch rtc-rtc-nuc900-add-__init-__exit-annotation.patch rtc-rtc-pcap-add-__init-__exit-annotation.patch rtc-rtc-tegra-add-__init-__exit-annotation.patch rtc-add-devm_rtc_device_registerunregister.patch rtc-max77686-use-module_platform_driver.patch rtc-max77686-add-missing-module-author-name.patch rtc-max77686-use-devm_kzalloc.patch rtc-max77686-fix-indentation-of-bit-definitions.patch rtc-max77686-use-dev_info-dev_emerg-instead-of-pr_info-pr_emerg.patch rtc-rtc-v3020-use-gpio_request_array.patch rtc-use-struct-device-as-the-first-argument-for-devm_rtc_device_register.patch rtc-rtc-ab3100-use-module_platform_driver_probe.patch rtc-rtc-at32ap700x-use-module_platform_driver_probe.patch rtc-rtc-at91rm9200-use-module_platform_driver_probe.patch rtc-rtc-au1xxx-use-module_platform_driver_probe.patch rtc-rtc-coh901331-use-module_platform_driver_probe.patch rtc-rtc-davinci-use-module_platform_driver_probe.patch rtc-rtc-ds1302-use-module_platform_driver_probe.patch rtc-rtc-efi-use-module_platform_driver_probe.patch rtc-rtc-generic-use-module_platform_driver_probe.patch rtc-rtc-imxdi-use-module_platform_driver_probe.patch rtc-rtc-mc13xxx-use-module_platform_driver_probe.patch rtc-rtc-msm6242-use-module_platform_driver_probe.patch rtc-rtc-mv-use-module_platform_driver_probe.patch rtc-rtc-nuc900-use-module_platform_driver_probe.patch rtc-rtc-omap-use-module_platform_driver_probe.patch rtc-rtc-pcap-use-module_platform_driver_probe.patch rtc-rtc-ps3-use-module_platform_driver_probe.patch rtc-rtc-pxa-use-module_platform_driver_probe.patch rtc-rtc-rp5c01-use-module_platform_driver_probe.patch rtc-rtc-sh-use-module_platform_driver_probe.patch rtc-rtc-starfire-use-module_platform_driver_probe.patch rtc-rtc-sun4v-use-module_platform_driver_probe.patch rtc-rtc-tegra-use-module_platform_driver_probe.patch rtc-rtc-tx4939-use-module_platform_driver_probe.patch rtc-rtc-88pm80x-use-devm_rtc_device_register.patch rtc-rtc-coh90133-use-devm_rtc_device_register.patch rtc-rtc-da9052-use-devm_rtc_device_register.patch rtc-rtc-da9055-use-devm_rtc_device_register.patch rtc-rtc-davinci-use-devm_rtc_device_register.patch rtc-rtc-ds1511-use-devm_rtc_device_register.patch rtc-rtc-ds1553-use-devm_rtc_device_register.patch rtc-rtc-ds1742-use-devm_rtc_device_register.patch rtc-rtc-ep93xx-use-devm_rtc_device_register.patch rtc-rtc-imxdi-use-devm_rtc_device_register.patch rtc-rtc-lp8788-use-devm_rtc_device_register.patch rtc-rtc-lpc32xx-use-devm_rtc_device_register.patch rtc-rtc-max77686-use-devm_rtc_device_register.patch rtc-rtc-max8907-use-devm_rtc_device_register.patch rtc-rtc-max8997-use-devm_rtc_device_register.patch rtc-rtc-mv-use-devm_rtc_device_register.patch rtc-rtc-mxc-use-devm_rtc_device_register.patch rtc-rtc-palmas-use-devm_rtc_device_register.patch rtc-rtc-pcf8523-use-devm_rtc_device_register.patch rtc-rtc-s3c-use-devm_rtc_device_register.patch rtc-rtc-snvs-use-devm_rtc_device_register.patch rtc-rtc-spear-use-devm_rtc_device_register.patch rtc-rtc-stk17ta8-use-devm_rtc_device_register.patch rtc-rtc-tps6586x-use-devm_rtc_device_register.patch rtc-rtc-tps65910-use-devm_rtc_device_register.patch rtc-rtc-tps80031-use-devm_rtc_device_register.patch rtc-rtc-tx4939-use-devm_rtc_device_register.patch rtc-rtc-vt8500-use-devm_rtc_device_register.patch rtc-rtc-wm831x-use-devm_rtc_device_register.patch rtc-tegra-protect-suspend-resume-callbacks-with-config_pm_sleep.patch rtc-tegra-use-struct-dev_pm_ops-for-power-management.patch rtc-tegra-set-irq-name-as-device-name.patch rtc-tegra-use-managed-rtc_device_register.patch rtc-rtc-palmas-use-devm_request_threaded_irq.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html