The patch titled Subject: loopdev: update block device size in loop_set_status() has been added to the -mm tree. Its filename is loopdev-update-block-device-size-in-loop_set_status.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Guo Chao <yan@xxxxxxxxxxxxxxxxxx> Subject: loopdev: update block device size in loop_set_status() Loop device driver sometimes fails to impose the size limit on the device. Keep issuing following two commands: losetup --offset 7517244416 --sizelimit 3224971264 /dev/loop0 backed_file blockdev --getsize64 /dev/loop0 blockdev reports file size instead of sizelimit several out of 100 times. The problems are: - losetup set up the device in two ioctl: LOOP_SET_FD and LOOP_SET_STATUS64. - LOOP_SET_STATUS64 only update size of gendisk. Block device size will be updated lazily when device comes to use. If udev rushes in between the two ioctl, it will bring in a block device whose size is backing file size. If the device is not released after LOOP_SET_STATUS64 ioctl, blockdev will not see the updated size. Update block size in LOOP_SET_STATUS64 ioctl. Signed-off-by: Guo Chao <yan@xxxxxxxxxxxxxxxxxx> Reported-by: M. Hindess <hindessm@xxxxxxxxxx> Cc: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx> Cc: Guo Chao <yan@xxxxxxxxxxxxxxxxxx> Cc: Nikanth Karthikesan <knikanth@xxxxxxx> Cc: Jens Axboe <axboe@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/block/loop.c | 5 +++++ 1 file changed, 5 insertions(+) diff -puN drivers/block/loop.c~loopdev-update-block-device-size-in-loop_set_status drivers/block/loop.c --- a/drivers/block/loop.c~loopdev-update-block-device-size-in-loop_set_status +++ a/drivers/block/loop.c @@ -1092,8 +1092,13 @@ loop_set_status(struct loop_device *lo, if (lo->lo_offset != info->lo_offset || lo->lo_sizelimit != info->lo_sizelimit) { + struct block_device *bdev = lo->lo_device; + if (figure_loop_size(lo, info->lo_offset, info->lo_sizelimit)) return -EFBIG; + + bd_set_size(bdev, (loff_t)get_capacity(bdev->bd_disk) << 9); + kobject_uevent(&disk_to_dev(bdev->bd_disk)->kobj, KOBJ_CHANGE); } loop_config_discard(lo); _ Patches currently in -mm which might be from yan@xxxxxxxxxxxxxxxxxx are linux-next.patch block-use-i_size_write-in-bd_set_size.patch block-remove-redundant-check-to-bd_openers.patch loopdev-fix-a-deadlock.patch loopdev-update-block-device-size-in-loop_set_status.patch loopdev-move-common-code-into-loop_figure_size.patch loopdev-remove-an-user-triggerable-oops.patch loopdev-ignore-negative-offset-when-calculate-loop-device-size.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html