The patch titled Subject: rtc-add-support-for-spi-rtc-rx4581-checkpatch-fixes has been added to the -mm tree. Its filename is rtc-add-support-for-spi-rtc-rx4581-checkpatch-fixes.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Subject: rtc-add-support-for-spi-rtc-rx4581-checkpatch-fixes WARNING: quoted string split across lines #171: FILE: drivers/rtc/rtc-rx4581.c:126: + dev_err(dev, "Unable to write device " + "flags\n"); WARNING: quoted string split across lines #214: FILE: drivers/rtc/rtc-rx4581.c:169: + dev_dbg(dev, "%s: tm is secs=%d, mins=%d, hours=%d, " + "mday=%d, mon=%d, year=%d, wday=%d\n", WARNING: quoted string split across lines #233: FILE: drivers/rtc/rtc-rx4581.c:188: + dev_dbg(dev, "%s: secs=%d, mins=%d, hours=%d, " + "mday=%d, mon=%d, year=%d, wday=%d\n", WARNING: Using __devinit is unnecessary #310: FILE: drivers/rtc/rtc-rx4581.c:265: +static int __devinit rx4581_probe(struct spi_device *spi) WARNING: Using __devexit is unnecessary #329: FILE: drivers/rtc/rtc-rx4581.c:284: +static int __devexit rx4581_remove(struct spi_device *spi) WARNING: space prohibited between function name and open parenthesis '(' #355: FILE: drivers/rtc/rtc-rx4581.c:310: +MODULE_DESCRIPTION ("rx4581 spi RTC driver"); WARNING: space prohibited between function name and open parenthesis '(' #356: FILE: drivers/rtc/rtc-rx4581.c:311: +MODULE_AUTHOR ("Torben Hohn"); WARNING: space prohibited between function name and open parenthesis '(' #357: FILE: drivers/rtc/rtc-rx4581.c:312: +MODULE_LICENSE ("GPL"); total: 0 errors, 8 warnings, 334 lines checked ./patches/rtc-add-support-for-spi-rtc-rx4581.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Torben Hohn <torbenh@xxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/rtc/rtc-rx4581.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff -puN drivers/rtc/Kconfig~rtc-add-support-for-spi-rtc-rx4581-checkpatch-fixes drivers/rtc/Kconfig diff -puN drivers/rtc/Makefile~rtc-add-support-for-spi-rtc-rx4581-checkpatch-fixes drivers/rtc/Makefile diff -puN drivers/rtc/rtc-rx4581.c~rtc-add-support-for-spi-rtc-rx4581-checkpatch-fixes drivers/rtc/rtc-rx4581.c --- a/drivers/rtc/rtc-rx4581.c~rtc-add-support-for-spi-rtc-rx4581-checkpatch-fixes +++ a/drivers/rtc/rtc-rx4581.c @@ -262,7 +262,7 @@ static const struct rtc_class_ops rx4581 .set_time = rx4581_set_datetime, }; -static int __devinit rx4581_probe(struct spi_device *spi) +static int rx4581_probe(struct spi_device *spi) { struct rtc_device *rtc; unsigned char tmp; @@ -281,7 +281,7 @@ static int __devinit rx4581_probe(struct return 0; } -static int __devexit rx4581_remove(struct spi_device *spi) +static int rx4581_remove(struct spi_device *spi) { struct rtc_device *rtc = dev_get_drvdata(&spi->dev); @@ -307,7 +307,7 @@ static struct spi_driver rx4581_driver = module_spi_driver(rx4581_driver); -MODULE_DESCRIPTION ("rx4581 spi RTC driver"); -MODULE_AUTHOR ("Torben Hohn"); -MODULE_LICENSE ("GPL"); +MODULE_DESCRIPTION("rx4581 spi RTC driver"); +MODULE_AUTHOR("Torben Hohn"); +MODULE_LICENSE("GPL"); MODULE_ALIAS("spi:rtc-rx4581"); _ Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are origin.patch linux-next.patch linux-next-git-rejects.patch make-my-i386-build-work.patch arch-alpha-kernel-systblss-remove-debug-check.patch bugh-prevent-double-evaulation-of-in-build_bug_on-fix.patch bugh-compilerh-introduce-compiletime_assert-build_bug_on_msg-checkpatch-fixes.patch i-need-old-gcc.patch lib-cpu_rmap-avoid-flushing-all-workqueues-fix.patch drivers-rtc-rtc-da9055c-fix-cross-section-reference.patch arch-mn10300-kconfig-select-config_generic_atomic64.patch arch-x86-tools-insn_sanityc-identify-source-of-messages.patch kernel-auditc-avoid-negative-sleep-durations.patch fb-rework-locking-to-fix-lock-ordering-on-takeover-fix.patch fb-rework-locking-to-fix-lock-ordering-on-takeover-fix-2.patch mm.patch mm-memcontrolc-convert-printkkern_foo-to-pr_foo.patch mm-hugetlbc-convert-to-pr_foo.patch cma-make-putback_lru_pages-call-conditional-fix.patch mm-vmscan-clean-up-get_scan_count-fix.patch mm-vmscan-compaction-works-against-zones-not-lruvecs-fix.patch mm-page_allocc-__setup_per_zone_wmarks-make-min_pages-unsigned-long.patch mm-vmscanc-__zone_reclaim-replace-max_t-with-max.patch mm-make-madvisemadv_willneed-support-swap-file-prefetch-fix.patch mm-compaction-make-__compact_pgdat-and-compact_pgdat-return-void.patch drop_caches-add-some-documentation-and-info-messsge.patch memcg-debugging-facility-to-access-dangling-memcgs-fix.patch scripts-pnmtologo-fix-for-plain-pbm-checkpatch-fixes.patch kernel-smpc-cleanups.patch backlight-add-lms501kf03-lcd-driver-fix.patch backlight-add-lms501kf03-lcd-driver-fix-fix.patch backlight-add-new-lp8788-backlight-driver-checkpatch-fixes.patch binfmt_elfc-use-get_random_int-to-fix-entropy-depleting.patch rtc-ds1307-long-block-operations-bugfix-fix.patch rtc-max77686-add-maxim-77686-driver-fix.patch rtc-pcf8523-add-low-battery-voltage-support-fix.patch rtc-add-rtc-driver-for-tps80031-tps80032-v2-fix.patch rtc-add-support-for-spi-rtc-rx4581-checkpatch-fixes.patch hfsplus-add-osx-prefix-for-handling-namespace-of-mac-os-x-extended-attributes.patch drivers-char-miscc-misc_register-do-not-loop-on-misc_list-unconditionally-fix.patch dma-debug-new-interfaces-to-debug-dma-mapping-errors-fix-fix.patch aio-kiocb_cancel-fix.patch wait-add-wait_event_hrtimeout-fix.patch aio-give-shared-kioctx-fields-their-own-cachelines-fix.patch generic-dynamic-per-cpu-refcounting-fix.patch generic-dynamic-per-cpu-refcounting-fix-fix.patch generic-dynamic-per-cpu-refcounting-sparse-fixes-fix.patch generic-dynamic-per-cpu-refcounting-doc-fix.patch aio-dont-include-aioh-in-schedh-fix.patch aio-dont-include-aioh-in-schedh-fix-fix.patch aio-dont-include-aioh-in-schedh-fix-3.patch aio-kill-ki_retry-fix.patch block-aio-batch-completion-for-bios-kiocbs-fix.patch block-aio-batch-completion-for-bios-kiocbs-fix-fix.patch block-aio-batch-completion-for-bios-kiocbs-fix-fix-fix.patch aio-smoosh-struct-kiocb-fix.patch journal_add_journal_head-debug.patch kernel-forkc-export-kernel_thread-to-modules.patch mutex-subsystem-synchro-test-module.patch slab-leaks3-default-y.patch put_bh-debug.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html