The patch titled Subject: mm: memblock: fix wrong memmove size in memblock_merge_regions() has been added to the -mm tree. Its filename is mm-memblock-fix-wrong-memmove-size-in-memblock_merge_regions.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Lin Feng <linfeng@xxxxxxxxxxxxxx> Subject: mm: memblock: fix wrong memmove size in memblock_merge_regions() The memmove span covers from (next+1) to the end of the array, and the index of next is (i+1), so the index of (next+1) is (i+2). So the size of remaining array elements is (type->cnt - (i + 2)). Signed-off-by: Lin Feng <linfeng@xxxxxxxxxxxxxx> Acked-by: Tejun Heo <tj@xxxxxxxxxx> Reviewed-by: Wanpeng Li <liwanp@xxxxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- mm/memblock.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -puN mm/memblock.c~mm-memblock-fix-wrong-memmove-size-in-memblock_merge_regions mm/memblock.c --- a/mm/memblock.c~mm-memblock-fix-wrong-memmove-size-in-memblock_merge_regions +++ a/mm/memblock.c @@ -314,7 +314,8 @@ static void __init_memblock memblock_mer } this->size += next->size; - memmove(next, next + 1, (type->cnt - (i + 1)) * sizeof(*next)); + /* move forward from next + 1, index of which is i + 2 */ + memmove(next, next + 1, (type->cnt - (i + 2)) * sizeof(*next)); type->cnt--; } } _ Patches currently in -mm which might be from linfeng@xxxxxxxxxxxxxx are mm-memblock-fix-wrong-memmove-size-in-memblock_merge_regions.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html