The patch titled Subject: core_pattern-set-core-helpers-root-and-namespace-to-crashing-process-fix has been added to the -mm tree. Its filename is core_pattern-set-core-helpers-root-and-namespace-to-crashing-process-fix.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Subject: core_pattern-set-core-helpers-root-and-namespace-to-crashing-process-fix fix doc typo, simplify format_corename() Cc: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx> Cc: Daniel Berrange <berrange@xxxxxxxxxx> Cc: Neil Horman <nhorman@xxxxxxxxxxxxx> Cc: Serge Hallyn <serge.hallyn@xxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- Documentation/sysctl/kernel.txt | 2 +- fs/coredump.c | 10 ++++------ 2 files changed, 5 insertions(+), 7 deletions(-) diff -puN Documentation/sysctl/kernel.txt~core_pattern-set-core-helpers-root-and-namespace-to-crashing-process-fix Documentation/sysctl/kernel.txt --- a/Documentation/sysctl/kernel.txt~core_pattern-set-core-helpers-root-and-namespace-to-crashing-process-fix +++ a/Documentation/sysctl/kernel.txt @@ -194,7 +194,7 @@ core_pattern is used to specify a core d written to the standard input of that program instead of to a file. Note that when using |, the core pipe reader that is executed will be run in the global namespace and root filesystem. If two | tokens (i.e. ||) are supplied as the - first two characters of the core_pattern sysctl, the kernel will preform the + first two characters of the core_pattern sysctl, the kernel will perform the same pipe operation, but the core pipe reader will be executed using the namespace and root fs of the crashing process. diff -puN fs/coredump.c~core_pattern-set-core-helpers-root-and-namespace-to-crashing-process-fix fs/coredump.c --- a/fs/coredump.c~core_pattern-set-core-helpers-root-and-namespace-to-crashing-process-fix +++ a/fs/coredump.c @@ -164,16 +164,14 @@ static int format_corename(struct core_n if (!cn->corename) return -ENOMEM; - if (ispipe) { + if (ispipe && pat_ptr[1] == '|') { /* - * If we have 2 | tokens at the head of core_pattern, it + * We have 2 | tokens at the head of core_pattern which * indicates we are a pipe and the reader should inherit the * namespaces of the crashing process */ - cprm->switch_ns = (*(pat_ptr+1) == '|') ? true : false; - if (cprm->switch_ns) - /* Advance pat_ptr so as not to mess up corename */ - pat_ptr++; + cprm->switch_ns = true; + pat_ptr++; } /* Repeat as long as we have more pattern to process and more output _ Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are origin.patch linux-next.patch linux-next-rejects-git-rejects.patch i-need-old-gcc.patch arch-alpha-kernel-systblss-remove-debug-check.patch arch-x86-platform-iris-irisc-register-a-platform-device-and-a-platform-driver.patch arch-x86-tools-insn_sanityc-identify-source-of-messages.patch fb-rework-locking-to-fix-lock-ordering-on-takeover-fix.patch fb-rework-locking-to-fix-lock-ordering-on-takeover-fix-2.patch irq-tsk-comm-is-an-array.patch block-remove-deadlock-in-disk_clear_events-fix.patch block-prevent-race-cleanup-fix.patch mm.patch memcg-kmem-accounting-basic-infrastructure-fix.patch slub-slub-specific-propagation-changes-fix.patch mm-mprotectc-coding-style-cleanups.patch mm-hugetlb-create-hugetlb-cgroup-file-in-hugetlb_init-fix.patch drop_caches-add-some-documentation-and-info-messsge-checkpatch-fixes.patch swap-add-a-simple-detector-for-inappropriate-swapin-readahead-fix.patch memcg-debugging-facility-to-access-dangling-memcgs-fix.patch scripts-pnmtologo-fix-for-plain-pbm-checkpatch-fixes.patch lseek-the-whence-argument-is-called-whence.patch drivers-video-backlight-lp855x_blc-use-generic-pwm-functions-fix.patch backlight-add-of_find_backlight_by_node-function-fix.patch backlight-88pm860x_bl-remove-an-unnecessary-line-continuation-fix.patch drivers-firmware-dmi_scanc-check-dmi-version-when-get-system-uuid-fix.patch drivers-firmware-dmi_scanc-fetch-dmi-version-from-smbios-if-it-exists-checkpatch-fixes.patch binfmt_elf-fix-corner-case-kfree-of-uninitialized-data-checkpatch-fixes.patch binfmt_elfc-use-get_random_int-to-fix-entropy-depleting.patch rtc-avoid-calling-platform_device_put-twice-in-test_init-fix.patch hfsplus-add-osx-prefix-for-handling-namespace-of-mac-os-x-extended-attributes-checkpatch-fixes.patch hfsplus-rework-processing-of-hfs_btree_write-returned-error-fix.patch core_pattern-set-core-helpers-root-and-namespace-to-crashing-process-fix.patch procfs-add-vmflags-field-in-smaps-output-v4.patch procfs-add-vmflags-field-in-smaps-output-v4-fix.patch ipc-add-sysctl-to-specify-desired-next-object-id-checkpatch-fixes.patch ipc-message-queue-receive-cleanup-checkpatch-fixes.patch ipc-convert-prepare_copy-from-macro-to-function-fix.patch dma-debug-new-interfaces-to-debug-dma-mapping-errors-fix-fix.patch docs-add-documentation-about-proc-pid-fdinfo-fd-output-fix.patch fs-notify-add-procfs-fdinfo-helper-v7-fix.patch scatterlist-dont-bug-when-we-can-trivially-return-a-proper-error-fix.patch journal_add_journal_head-debug.patch kernel-forkc-export-kernel_thread-to-modules.patch mutex-subsystem-synchro-test-module-fix.patch slab-leaks3-default-y.patch put_bh-debug.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html