The patch titled Subject: drivers-video-add-support-for-the-solomon-ssd1307-oled-controller-checkpatch-fixes has been added to the -mm tree. Its filename is drivers-video-add-support-for-the-solomon-ssd1307-oled-controller-checkpatch-fixes.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Subject: drivers-video-add-support-for-the-solomon-ssd1307-oled-controller-checkpatch-fixes WARNING: line over 80 characters #150: FILE: drivers/video/ssd1307fb.c:58: +static int ssd1307fb_write_array(struct i2c_client *client, u8 type, u8* cmd, u32 len) ERROR: "foo* bar" should be "foo *bar" #150: FILE: drivers/video/ssd1307fb.c:58: +static int ssd1307fb_write_array(struct i2c_client *client, u8 type, u8* cmd, u32 len) WARNING: line over 80 characters #175: FILE: drivers/video/ssd1307fb.c:83: +static inline int ssd1307fb_write_cmd_array(struct i2c_client *client, u8* cmd, u32 len) ERROR: "foo* bar" should be "foo *bar" #175: FILE: drivers/video/ssd1307fb.c:83: +static inline int ssd1307fb_write_cmd_array(struct i2c_client *client, u8* cmd, u32 len) WARNING: line over 80 characters #185: FILE: drivers/video/ssd1307fb.c:93: +static inline int ssd1307fb_write_data_array(struct i2c_client *client, u8* cmd, u32 len) ERROR: "foo* bar" should be "foo *bar" #185: FILE: drivers/video/ssd1307fb.c:93: +static inline int ssd1307fb_write_data_array(struct i2c_client *client, u8* cmd, u32 len) WARNING: line over 80 characters #230: FILE: drivers/video/ssd1307fb.c:138: + ssd1307fb_write_cmd(par->client, SSD1307FB_START_PAGE_ADDRESS + (i + 1)); WARNING: line over 80 characters #238: FILE: drivers/video/ssd1307fb.c:146: + u32 index = page_length + (SSD1307FB_WIDTH * k + j) / 8; WARNING: line over 80 characters #281: FILE: drivers/video/ssd1307fb.c:189: +static void ssd1307fb_fillrect(struct fb_info *info, const struct fb_fillrect *rect) WARNING: line over 80 characters #288: FILE: drivers/video/ssd1307fb.c:196: +static void ssd1307fb_copyarea(struct fb_info *info, const struct fb_copyarea *area) WARNING: line over 80 characters #295: FILE: drivers/video/ssd1307fb.c:203: +static void ssd1307fb_imageblit(struct fb_info *info, const struct fb_image *image) WARNING: line over 80 characters #322: FILE: drivers/video/ssd1307fb.c:230: +static int __devinit ssd1307fb_probe(struct i2c_client *client, const struct i2c_device_id *id) WARNING: line over 80 characters #396: FILE: drivers/video/ssd1307fb.c:304: + dev_dbg(&client->dev, "Using PWM%d with a %dns period.\n", par->pwm->pwm, par->pwm_period); WARNING: line over 80 characters #430: FILE: drivers/video/ssd1307fb.c:338: + dev_info(&client->dev, "fb%d: %s framebuffer device registered, using %d bytes of video memory\n", info->node, info->fix.id, vmem_size); total: 3 errors, 11 warnings, 446 lines checked ./patches/drivers-video-add-support-for-the-solomon-ssd1307-oled-controller.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Brian Lilly <brian@xxxxxxxxxxxxxxxx> Cc: Florian Tobias Schandinat <FlorianSchandinat@xxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/video/ssd1307fb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -puN drivers/video/ssd1307fb.c~drivers-video-add-support-for-the-solomon-ssd1307-oled-controller-checkpatch-fixes drivers/video/ssd1307fb.c --- a/drivers/video/ssd1307fb.c~drivers-video-add-support-for-the-solomon-ssd1307-oled-controller-checkpatch-fixes +++ a/drivers/video/ssd1307fb.c @@ -55,7 +55,7 @@ static struct fb_var_screeninfo ssd1307f .bits_per_pixel = 1, }; -static int ssd1307fb_write_array(struct i2c_client *client, u8 type, u8* cmd, u32 len) +static int ssd1307fb_write_array(struct i2c_client *client, u8 type, u8 *cmd, u32 len) { u8 *buf; int ret = 0; @@ -80,7 +80,7 @@ error: return ret; } -static inline int ssd1307fb_write_cmd_array(struct i2c_client *client, u8* cmd, u32 len) +static inline int ssd1307fb_write_cmd_array(struct i2c_client *client, u8 *cmd, u32 len) { return ssd1307fb_write_array(client, SSD1307FB_COMMAND, cmd, len); } @@ -90,7 +90,7 @@ static inline int ssd1307fb_write_cmd(st return ssd1307fb_write_cmd_array(client, &cmd, 1); } -static inline int ssd1307fb_write_data_array(struct i2c_client *client, u8* cmd, u32 len) +static inline int ssd1307fb_write_data_array(struct i2c_client *client, u8 *cmd, u32 len) { return ssd1307fb_write_array(client, SSD1307FB_DATA, cmd, len); } _ Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are linux-next.patch linux-next-git-rejects.patch i-need-old-gcc.patch arch-alpha-kernel-systblss-remove-debug-check.patch mm-export-a-function-to-get-vm-committed-memory.patch cpu_hotplug-unmap-cpu2node-when-the-cpu-is-hotremoved-fix.patch arch-x86-platform-iris-irisc-register-a-platform-device-and-a-platform-driver.patch arch-x86-tools-insn_sanityc-identify-source-of-messages.patch drivers-video-add-support-for-the-solomon-ssd1307-oled-controller-checkpatch-fixes.patch irq-tsk-comm-is-an-array.patch drivers-tty-serial-serial_corec-fix-uart_get_attr_port-shift.patch mm.patch mm-introduce-mm_find_pmd-fix.patch memory-hotplug-update-mce_bad_pages-when-removing-the-memory-fix.patch slub-hotplug-ignore-unrelated-nodes-hot-adding-and-hot-removing.patch mmvmscan-only-evict-file-pages-when-we-have-plenty-fix.patch slub-slub-specific-propagation-changes-fix.patch dmapool-make-dmapool_debug-detect-corruption-of-free-marker-fix.patch mm-support-more-pagesizes-for-map_hugetlb-shm_hugetlb-v7-fix.patch mm-support-more-pagesizes-for-map_hugetlb-shm_hugetlb-v7-fix-fix.patch mm-support-more-pagesizes-for-map_hugetlb-shm_hugetlb-v7-fix-fix-fix-fix-checkpatch-fixes.patch mm-check-rb_subtree_gap-correctness-fix.patch mm-rearrange-vm_area_struct-for-fewer-cache-misses-checkpatch-fixes.patch mm-vm_unmapped_area-lookup-function-checkpatch-fixes.patch mm-use-vm_unmapped_area-in-hugetlbfs-on-i386-architecture-fix.patch mm-use-vm_unmapped_area-on-mips-architecture-fix.patch mm-use-vm_unmapped_area-on-arm-architecture-fix.patch mm-use-vm_unmapped_area-on-arm-architecture-fix-fix.patch mm-use-vm_unmapped_area-on-sh-architecture-fix.patch mm-use-vm_unmapped_area-on-sparc32-architecture-fix.patch mm-use-vm_unmapped_area-on-sparc32-architecture-fix-fix.patch mm-use-vm_unmapped_area-in-hugetlbfs-on-tile-architecture-fix.patch mm-use-vm_unmapped_area-on-sparc64-architecture-fix.patch arch-sparc-kernel-sys_sparc_64c-s-colour-color.patch virtio_balloon-introduce-migration-primitives-to-balloon-pages-fix-fix.patch virtio_balloon-introduce-migration-primitives-to-balloon-pages-fix-fix-fix.patch bootmem-fix-wrong-call-parameter-for-free_bootmem-fix.patch mm-memory-hotplug-dynamic-configure-movable-memory-and-portion-memory-fix.patch drop_caches-add-some-documentation-and-info-messsge-checkpatch-fixes.patch swap-add-a-simple-detector-for-inappropriate-swapin-readahead-fix.patch scripts-pnmtologo-fix-for-plain-pbm-checkpatch-fixes.patch drivers-video-backlight-lp855x_blc-use-generic-pwm-functions-fix.patch backlight-add-of_find_backlight_by_node-function-fix.patch backlight-88pm860x_bl-remove-an-unnecessary-line-continuation-fix.patch drivers-firmware-dmi_scanc-check-dmi-version-when-get-system-uuid-fix.patch drivers-firmware-dmi_scanc-fetch-dmi-version-from-smbios-if-it-exists-checkpatch-fixes.patch binfmt_elf-fix-corner-case-kfree-of-uninitialized-data-checkpatch-fixes.patch binfmt_elfc-use-get_random_int-to-fix-entropy-depleting.patch rtc-avoid-calling-platform_device_put-twice-in-test_init-fix.patch hfsplus-add-support-of-manipulation-by-attributes-file-checkpatch-fixes.patch procfs-add-vmflags-field-in-smaps-output-v4.patch procfs-add-vmflags-field-in-smaps-output-v4-fix.patch ipc-add-sysctl-to-specify-desired-next-object-id-checkpatch-fixes.patch ipc-message-queue-receive-cleanup-checkpatch-fixes.patch ipc-convert-prepare_copy-from-macro-to-function-fix.patch dma-debug-new-interfaces-to-debug-dma-mapping-errors-fix-fix.patch scatterlist-dont-bug-when-we-can-trivially-return-a-proper-error-fix.patch journal_add_journal_head-debug.patch kernel-forkc-export-kernel_thread-to-modules.patch mutex-subsystem-synchro-test-module-fix.patch slab-leaks3-default-y.patch put_bh-debug.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html