The patch titled
Subject: rtc: kconfig: fix RTC_INTF defaults connected to RTC_CLASS
has been added to the -mm tree. Its filename is
rtc-kconfig-fix-rtc_intf-defaults-connected-to-rtc_class.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Kevin Hilman <khilman@xxxxxx>
Subject: rtc: kconfig: fix RTC_INTF defaults connected to RTC_CLASS
commit 6b8029fab6416 ("rtc: kconfig: remove unnecessary dependencies")
removed various 'depends on RTC_CLASS' dependencies but also removed a few
'default RTC_CLASS' statements, which actually changed default behavior.
This resulted in the various RTC interfaces (sysfs, proc, dev) all being
disabled by default, even when RTC_CLASS is enabled:
# CONFIG_RTC_INTF_SYSFS is not set
# CONFIG_RTC_INTF_PROC is not set
# CONFIG_RTC_INTF_DEV is not set
which is different from previous behavior (all of these where enabled.)
To fix, add back the 'default RTC_CLASS' statments to each of the
RTC_INTF_* options.
I noticed this because some RTC tests started failing on my TI OMAP
platforms because /dev/rtc0 was not present anymore, even though the
driver was present and RTC_CLASS was enabled.
Signed-off-by: Kevin Hilman <khilman@xxxxxx>
Acked-by: Venu Byravarasu <vbyravarasu@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/rtc/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff -puN drivers/rtc/Kconfig~rtc-kconfig-fix-rtc_intf-defaults-connected-to-rtc_class drivers/rtc/Kconfig
--- a/drivers/rtc/Kconfig~rtc-kconfig-fix-rtc_intf-defaults-connected-to-rtc_class
+++ a/drivers/rtc/Kconfig
@@ -59,6 +59,7 @@ comment "RTC interfaces"
config RTC_INTF_SYSFS
boolean "/sys/class/rtc/rtcN (sysfs)"
depends on SYSFS
+ default RTC_CLASS
help
Say yes here if you want to use your RTCs using sysfs interfaces,
/sys/class/rtc/rtc0 through /sys/.../rtcN.
@@ -68,6 +69,7 @@ config RTC_INTF_SYSFS
config RTC_INTF_PROC
boolean "/proc/driver/rtc (procfs for rtcN)"
depends on PROC_FS
+ default RTC_CLASS
help
Say yes here if you want to use your system clock RTC through
the proc interface, /proc/driver/rtc.
@@ -79,6 +81,7 @@ config RTC_INTF_PROC
config RTC_INTF_DEV
boolean "/dev/rtcN (character devices)"
+ default RTC_CLASS
help
Say yes here if you want to use your RTCs using the /dev
interfaces, which "udev" sets up as /dev/rtc0 through
_
Patches currently in -mm which might be from khilman@xxxxxx are
origin.patch
linux-next.patch
rtc-kconfig-fix-rtc_intf-defaults-connected-to-rtc_class.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
