The patch titled Subject: drivers/rtc/rtc-ds1672.c: convert struct i2c_msg initialization to C99 format has been added to the -mm tree. Its filename is drivers-rtc-rtc-ds1672c-convert-struct-i2c_msg-initialization-to-c99-format.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Shubhrajyoti D <shubhrajyoti@xxxxxx> Subject: drivers/rtc/rtc-ds1672.c: convert struct i2c_msg initialization to C99 format Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D <shubhrajyoti@xxxxxx> Reviewed-by: Felipe Balbi <balbi@xxxxxx> Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/rtc/rtc-ds1672.c | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-) diff -puN drivers/rtc/rtc-ds1672.c~drivers-rtc-rtc-ds1672c-convert-struct-i2c_msg-initialization-to-c99-format drivers/rtc/rtc-ds1672.c --- a/drivers/rtc/rtc-ds1672.c~drivers-rtc-rtc-ds1672c-convert-struct-i2c_msg-initialization-to-c99-format +++ a/drivers/rtc/rtc-ds1672.c @@ -37,8 +37,17 @@ static int ds1672_get_datetime(struct i2 unsigned char buf[4]; struct i2c_msg msgs[] = { - {client->addr, 0, 1, &addr}, /* setup read ptr */ - {client->addr, I2C_M_RD, 4, buf}, /* read date */ + {/* setup read ptr */ + .addr = client->addr, + .len = 1, + .buf = &addr + }, + {/* read date */ + .addr = client->addr, + .flags = I2C_M_RD, + .len = 4, + .buf = buf + }, }; /* read date registers */ @@ -99,8 +108,17 @@ static int ds1672_get_control(struct i2c unsigned char addr = DS1672_REG_CONTROL; struct i2c_msg msgs[] = { - {client->addr, 0, 1, &addr}, /* setup read ptr */ - {client->addr, I2C_M_RD, 1, status}, /* read control */ + {/* setup read ptr */ + .addr = client->addr, + .len = 1, + .buf = &addr + }, + {/* read control */ + .addr = client->addr, + .flags = I2C_M_RD, + .len = 1, + .buf = status + }, }; /* read control register */ _ Patches currently in -mm which might be from shubhrajyoti@xxxxxx are linux-next.patch drivers-rtc-rtc-ds1672c-convert-struct-i2c_msg-initialization-to-c99-format.patch drivers-rtc-rtc-x1205c-convert-struct-i2c_msg-initialization-to-c99-format.patch drivers-rtc-rtc-s35390ac-convert-struct-i2c_msg-initialization-to-c99-format.patch drivers-rtc-rtc-rs5c372c-convert-struct-i2c_msg-initialization-to-c99-format.patch drivers-rtc-rtc-pcf8563c-convert-struct-i2c_msg-initialization-to-c99-format.patch drivers-rtc-rtc-isl1208c-convert-struct-i2c_msg-initialization-to-c99-format.patch drivers-rtc-rtc-em3027c-convert-struct-i2c_msg-initialization-to-c99-format.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html