The patch titled
Subject: net: do not disable sg for AoE
has been added to the -mm tree. Its filename is
net-do-not-disable-sg-for-aoe.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Ed Cashin <ecashin@xxxxxxxxxx>
Subject: net: do not disable sg for AoE
A change in a series of VLAN-related changes appears to have inadvertently
disabled the use of the scatter gather feature of network cards for
transmission of non-IP ethernet protocols like ATA over Ethernet (AoE).
Below is a reference to the commit that introduces a "harmonize_features"
function that turns off scatter gather when the NIC does not support
hardware checksumming for the ethernet protocol of an sk buff.
commit f01a5236bd4b140198fbcc550f085e8361fd73fa
Author: Jesse Gross <jesse@xxxxxxxxxx>
Date: Sun Jan 9 06:23:31 2011 +0000
net offloading: Generalize netif_get_vlan_features().
The can_checksum_protocol function is not equipped to consider a protocol
that does not require checksumming. Calling it for a protocol that
requires no checksum is inappropriate.
The patch below has harmonize_features call can_checksum_protocol when the
protocol needs a checksum, so that the network layer is not forced to
perform unnecessary skb linearization on the transmission of AoE packets.
Unnecessary linearization results in decreased performance and increased
memory pressure, as reported here:
http://www.spinics.net/lists/linux-mm/msg15184.html
The problem has probably not been widely experienced yet, because only
recently has the kernel.org-distributed aoe driver acquired the ability to
use payloads of over a page in size, with the patchset recently included
in the mm tree:
https://lkml.org/lkml/2012/8/28/140
The coraid.com-distributed aoe driver already could use payloads of
greater than a page in size, but its users generally do not use the newest
kernels.
Signed-off-by: Ed Cashin <ecashin@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
net/core/dev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN net/core/dev.c~net-do-not-disable-sg-for-aoe net/core/dev.c
--- a/net/core/dev.c~net-do-not-disable-sg-for-aoe
+++ a/net/core/dev.c
@@ -2144,7 +2144,8 @@ static bool can_checksum_protocol(netdev
static netdev_features_t harmonize_features(struct sk_buff *skb,
__be16 protocol, netdev_features_t features)
{
- if (!can_checksum_protocol(features, protocol)) {
+ if (protocol != htons(ETH_P_AOE) &&
+ !can_checksum_protocol(features, protocol)) {
features &= ~NETIF_F_ALL_CSUM;
features &= ~NETIF_F_SG;
} else if (illegal_highdma(skb->dev, skb)) {
_
Patches currently in -mm which might be from ecashin@xxxxxxxxxx are
net-do-not-disable-sg-for-aoe.patch
aoe-for-performance-support-larger-packet-payloads.patch
aoe-kernel-thread-handles-i-o-completions-for-simple-locking.patch
aoe-kernel-thread-handles-i-o-completions-for-simple-locking-fix.patch
aoe-become-i-o-request-queue-handler-for-increased-user-control.patch
aoe-use-a-kernel-thread-for-transmissions.patch
aoe-use-packets-that-work-with-the-smallest-mtu-local-interface.patch
aoe-failover-remote-interface-based-on-aoe_deadsecs-parameter.patch
aoe-do-revalidation-steps-in-order.patch
aoe-disallow-unsupported-aoe-minor-addresses.patch
aoe-associate-frames-with-the-aoe-storage-target.patch
aoe-increase-net_device-reference-count-while-using-it.patch
aoe-remove-unused-code-and-add-cosmetic-improvements.patch
aoe-update-internal-version-number-to-49.patch
aoe-update-copyright-year-in-touched-files.patch
aoe-update-documentation-with-new-url-and-vm-settings-reference.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
