The patch titled Subject: coredump: use SUID_DUMPABLE_ENABLED rather than hardcoded 1 has been added to the -mm tree. Its filename is coredump-use-suid_dumpable_enabled-rather-than-hardcoded-1.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Oleg Nesterov <oleg@xxxxxxxxxx> Subject: coredump: use SUID_DUMPABLE_ENABLED rather than hardcoded 1 Cosmetic. Change setup_new_exec() and task_dumpable() to use SUID_DUMPABLE_ENABLED for /bin/grep. Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/exec.c | 2 +- fs/proc/base.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff -puN fs/exec.c~coredump-use-suid_dumpable_enabled-rather-than-hardcoded-1 fs/exec.c --- a/fs/exec.c~coredump-use-suid_dumpable_enabled-rather-than-hardcoded-1 +++ a/fs/exec.c @@ -1125,7 +1125,7 @@ void setup_new_exec(struct linux_binprm current->sas_ss_sp = current->sas_ss_size = 0; if (uid_eq(current_euid(), current_uid()) && gid_eq(current_egid(), current_gid())) - set_dumpable(current->mm, 1); + set_dumpable(current->mm, SUID_DUMPABLE_ENABLED); else set_dumpable(current->mm, suid_dumpable); diff -puN fs/proc/base.c~coredump-use-suid_dumpable_enabled-rather-than-hardcoded-1 fs/proc/base.c --- a/fs/proc/base.c~coredump-use-suid_dumpable_enabled-rather-than-hardcoded-1 +++ a/fs/proc/base.c @@ -1398,7 +1398,7 @@ static int task_dumpable(struct task_str if (mm) dumpable = get_dumpable(mm); task_unlock(task); - if(dumpable == 1) + if(dumpable == SUID_DUMPABLE_ENABLED) return 1; return 0; } _ Patches currently in -mm which might be from oleg@xxxxxxxxxx are pid-namespace-limit-value-of-ns_last_pid-to-0-max_pid.patch linux-next.patch x86-pat-remove-the-dependency-on-vm_pgoff-in-track-untrack-pfn-vma-routines.patch x86-pat-separate-the-pfn-attribute-tracking-for-remap_pfn_range-and-vm_insert_pfn.patch mm-x86-pat-rework-linear-pfn-mmap-tracking.patch mm-introduce-arch-specific-vma-flag-vm_arch_1.patch mm-kill-vma-flag-vm_insertpage.patch mm-kill-vma-flag-vm_can_nonlinear.patch mm-use-mm-exe_file-instead-of-first-vm_executable-vma-vm_file.patch mm-kill-vma-flag-vm_executable-and-mm-num_exe_file_vmas.patch mm-prepare-vm_dontdump-for-using-in-drivers.patch mm-kill-vma-flag-vm_reserved-and-mm-reserved_vm-counter.patch coredump-prevent-double-free-on-an-error-path-in-core-dumper.patch coredump-add-support-for-%d=__get_dumpable-in-core-name.patch coredump-add-support-for-%d=__get_dumpable-in-core-name-fix.patch coredump-use-suid_dumpable_enabled-rather-than-hardcoded-1.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html