The patch titled
Subject: taskstats: cgroupstats_user_cmd() may leak on error
has been added to the -mm tree. Its filename is
taskstats-cgroupstats_user_cmd-may-leak-on-error.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Jesper Juhl <jj@xxxxxxxxxxxxx>
Subject: taskstats: cgroupstats_user_cmd() may leak on error
If prepare_reply() succeeds we have allocated memory for 'rep_skb'. If
nla_reserve() then subsequently fails and returns NULL we fail to release
the memory we allocated, thus causing a leak.
Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
Cc: Balbir Singh <bsingharora@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
kernel/taskstats.c | 1 +
1 file changed, 1 insertion(+)
diff -puN kernel/taskstats.c~taskstats-cgroupstats_user_cmd-may-leak-on-error kernel/taskstats.c
--- a/kernel/taskstats.c~taskstats-cgroupstats_user_cmd-may-leak-on-error
+++ a/kernel/taskstats.c
@@ -437,6 +437,7 @@ static int cgroupstats_user_cmd(struct s
na = nla_reserve(rep_skb, CGROUPSTATS_TYPE_CGROUP_STATS,
sizeof(struct cgroupstats));
if (na == NULL) {
+ nlmsg_free(rep_skb);
rc = -EMSGSIZE;
goto err;
}
_
Patches currently in -mm which might be from jj@xxxxxxxxxxxxx are
origin.patch
linux-next.patch
taskstats-cgroupstats_user_cmd-may-leak-on-error.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
