The patch titled Subject: rtc/rtc-88pm80x: assign ret only when rtc_register_driver fails has been added to the -mm tree. Its filename is rtc-rtc-88pm80x-assign-ret-only-when-rtc_register_driver-fails.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Devendra Naga <devendra.aaru@xxxxxxxxx> Subject: rtc/rtc-88pm80x: assign ret only when rtc_register_driver fails At the probe we are assigning ret to return value of PTR_ERR right after the rtc_register_drive()r, as we would have done it in the if (IS_ERR(ptr)) check, since the function fails and goes inside that case Signed-off-by: Devendra Naga <devendra.aaru@xxxxxxxxx> Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx> Cc: Ashish Jangam <ashish.jangam@xxxxxxxxxxxxxxx> Cc: David Dajun Chen <dchen@xxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/rtc/rtc-88pm80x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/rtc/rtc-88pm80x.c~rtc-rtc-88pm80x-assign-ret-only-when-rtc_register_driver-fails drivers/rtc/rtc-88pm80x.c --- a/drivers/rtc/rtc-88pm80x.c~rtc-rtc-88pm80x-assign-ret-only-when-rtc_register_driver-fails +++ a/drivers/rtc/rtc-88pm80x.c @@ -314,8 +314,8 @@ static int __devinit pm80x_rtc_probe(str info->rtc_dev = rtc_device_register("88pm80x-rtc", &pdev->dev, &pm80x_rtc_ops, THIS_MODULE); - ret = PTR_ERR(info->rtc_dev); if (IS_ERR(info->rtc_dev)) { + ret = PTR_ERR(info->rtc_dev); dev_err(&pdev->dev, "Failed to register RTC device: %d\n", ret); goto out_rtc; } _ Subject: Subject: rtc/rtc-88pm80x: assign ret only when rtc_register_driver fails Patches currently in -mm which might be from devendra.aaru@xxxxxxxxx are linux-next.patch drivers-rtc-rtc-r9701c-avoid-second-call-to-rtc_valid_tm.patch drivers-rtc-rtc-r9701c-check-that-r9701_set_datetime-succeeded.patch rtc-rtc-88pm80x-assign-ret-only-when-rtc_register_driver-fails.patch rtc-rtc-88pm80x-remove-unneed-devm_kfree.patch rtc-rtc-da9052-remove-unneed-devm_kfree-call.patch pps-return-ptr_err-on-error-in-device_create.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html