The patch titled
Subject: fs/sysv: remove another useless write_super call
has been added to the -mm tree. Its filename is
fs-sysv-remove-another-useless-write_super-call.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Artem Bityutskiy <artem.bityutskiy@xxxxxxxxxxxxxxx>
Subject: fs/sysv: remove another useless write_super call
We do not need to call 'sysv_write_super()' from 'sysv_remount()', because
VFS has called 'sysv_sync_fs()' before calling '->remount()'. So remove
it. Remove also '(un)lock_super()' which obvioulsy is becoming useless in
this function.
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@xxxxxxxxxxxxxxx>
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Cc: Christoph Hellwig <hch@xxxxxx>
Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/sysv/inode.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff -puN fs/sysv/inode.c~fs-sysv-remove-another-useless-write_super-call fs/sysv/inode.c
--- a/fs/sysv/inode.c~fs-sysv-remove-another-useless-write_super-call
+++ a/fs/sysv/inode.c
@@ -68,12 +68,9 @@ static void sysv_write_super(struct supe
static int sysv_remount(struct super_block *sb, int *flags, char *data)
{
struct sysv_sb_info *sbi = SYSV_SB(sb);
- lock_super(sb);
+
if (sbi->s_forced_ro)
*flags |= MS_RDONLY;
- if (*flags & MS_RDONLY)
- sysv_write_super(sb);
- unlock_super(sb);
return 0;
}
_
Subject: Subject: fs/sysv: remove another useless write_super call
Patches currently in -mm which might be from artem.bityutskiy@xxxxxxxxxxxxxxx are
origin.patch
linux-next.patch
hfs-push-lock_super-down.patch
hfs-get-rid-of-lock_super.patch
hfs-remove-extra-mdb-write-on-unmount.patch
hfs-simplify-a-bit-checking-for-r-o.patch
hfs-introduce-vfs-superblock-object-back-reference.patch
hfs-get-rid-of-hfs_sync_super.patch
hfs-get-rid-of-hfs_sync_super-checkpatch-fixes.patch
hfs-get-rid-of-hfs_sync_super-v2.patch
hfsplus-make-hfsplus_sync_fs-static.patch
hfsplus-amend-debugging-print.patch
hfsplus-remove-useless-check.patch
hfsplus-get-rid-of-write_super.patch
hfsplus-get-rid-of-write_super-checkpatch-fixes.patch
hfsplus-get-rid-of-write_super-v3.patch
fs-ufs-remove-extra-superblock-write-on-unmount.patch
fs-ufs-re-arrange-the-code-a-bit.patch
fs-ufs-re-arrange-the-code-a-bit-checkpatch-fixes.patch
fs-ufs-get-rid-of-write_super.patch
fs-sysv-remove-useless-write_super-call.patch
fs-sysv-remove-another-useless-write_super-call.patch
fs-sysv-stop-using-write_super-and-s_dirt.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
