The patch titled
Subject: fcoe: Remove redundant 'less than zero' check
has been added to the -mm tree. Its filename is
fcoe-remove-redundant-less-than-zero-check.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Robert Love <robert.w.love@xxxxxxxxx>
Subject: fcoe: Remove redundant 'less than zero' check
strtoul returns an 'unsigned long' so there is no reason to check if the
value is less than zero.
strtoul already checks for the '-' character deep in its bowels. It will
return an error if the user has provided a negative value and
fcoe_str_to_dev_loss will return that error to its caller.
This patch fixes the following Coverity reported warning:
CID 703581 - NO_EFFECT Unsigned compared against 0 - This
less-than-zero comparison of an unsigned value is never true. "*val < 0UL".
drivers/scsi/fcoe/fcoe_sysfs.c:105
Signed-off-by: Robert Love <robert.w.love@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/scsi/fcoe/fcoe_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/scsi/fcoe/fcoe_sysfs.c~fcoe-remove-redundant-less-than-zero-check drivers/scsi/fcoe/fcoe_sysfs.c
--- a/drivers/scsi/fcoe/fcoe_sysfs.c~fcoe-remove-redundant-less-than-zero-check
+++ a/drivers/scsi/fcoe/fcoe_sysfs.c
@@ -102,7 +102,7 @@ static int fcoe_str_to_dev_loss(const ch
int ret;
ret = kstrtoul(buf, 0, val);
- if (ret || *val < 0)
+ if (ret)
return -EINVAL;
/*
* Check for overflow; dev_loss_tmo is u32
_
Subject: Subject: fcoe: Remove redundant 'less than zero' check
Patches currently in -mm which might be from robert.w.love@xxxxxxxxx are
linux-next.patch
fcoe-remove-redundant-less-than-zero-check.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
