The patch titled
Subject: coredump: fix wrong comments on core limits of pipe coredump case
has been added to the -mm tree. Its filename is
coredump-fix-wrong-comments-on-core-limits-of-pipe-coredump-case.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Jovi Zhang <bookjovi@xxxxxxxxx>
Subject: coredump: fix wrong comments on core limits of pipe coredump case
In commit 898b374a ("exec: replace call_usermodehelper_pipe with use of
umh init function and resolve limit"), the core limits recursive check
value was changed from 0 to 1, but the corresponding comments were not
updated.
Signed-off-by: Jovi Zhang <bookjovi@xxxxxxxxx>
Cc: Oleg Nesterov <oleg@xxxxxxxxxx>
Cc: Neil Horman <nhorman@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/exec.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff -puN fs/exec.c~coredump-fix-wrong-comments-on-core-limits-of-pipe-coredump-case fs/exec.c
--- a/fs/exec.c~coredump-fix-wrong-comments-on-core-limits-of-pipe-coredump-case
+++ a/fs/exec.c
@@ -2174,15 +2174,16 @@ void do_coredump(long signr, int exit_co
}
if (cprm.limit == 1) {
- /*
+ /* See umh_pipe_setup() which sets RLIMIT_CORE = 1.
+ *
* Normally core limits are irrelevant to pipes, since
* we're not writing to the file system, but we use
- * cprm.limit of 1 here as a speacial value. Any
- * non-1 limit gets set to RLIM_INFINITY below, but
- * a limit of 0 skips the dump. This is a consistent
- * way to catch recursive crashes. We can still crash
- * if the core_pattern binary sets RLIM_CORE = !1
- * but it runs as root, and can do lots of stupid things
+ * cprm.limit of 1 here as a speacial value, this is a
+ * consistent way to catch recursive crashes.
+ * We can still crash if the core_pattern binary sets
+ * RLIM_CORE = !1, but it runs as root, and can do
+ * lots of stupid things.
+ *
* Note that we use task_tgid_vnr here to grab the pid
* of the process group leader. That way we get the
* right pid if a thread in a multi-threaded
_
Subject: Subject: coredump: fix wrong comments on core limits of pipe coredump case
Patches currently in -mm which might be from bookjovi@xxxxxxxxx are
linux-next.patch
coredump-fix-wrong-comments-on-core-limits-of-pipe-coredump-case.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
