The patch titled Subject: hfsplus: make hfsplus_sync_fs() static has been added to the -mm tree. Its filename is hfsplus-make-hfsplus_sync_fs-static.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Artem Bityutskiy <artem.bityutskiy@xxxxxxxxxxxxxxx> Subject: hfsplus: make hfsplus_sync_fs() static This patchset makes HFSPLUS file-system stop using the VFS '->write_supers()' callback and the '->s_dirt' superblock field because I plan to remove them once all users are gone. Like the other similar patchsets, we switch to a delayed job for writing out the superblock instead of using the 's_dirt' flag. Additionally, this patch-set includes several clean-ups. Reminder: The goal is to get rid of the 'sync_supers()' kernel thread. This kernel thread wakes up every 5 seconds (by default) and calls '->write_super()' for all mounted file-systems. And the bad thing is that this is done even if all the superblocks are clean. Moreover, many file-systems do not even need this end they do not register the '->write_super()' method at all (e.g., btrfs). So 'sync_supers()' most often just generates useless wakeups and wastes power. I am trying to make all filesystems independent of '->write_super()' and plan to remove 'sync_supers()' and '->write_super()' completely once there are no more users. Tested using the fsstress test from the LTP project. This patch: Make hfsplus_sync_fs() static because it is used only in fs/hfsplus/super.c. Signed-off-by: Artem Bityutskiy <artem.bityutskiy@xxxxxxxxxxxxxxx> Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/hfsplus/hfsplus_fs.h | 1 - fs/hfsplus/super.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff -puN fs/hfsplus/hfsplus_fs.h~hfsplus-make-hfsplus_sync_fs-static fs/hfsplus/hfsplus_fs.h --- a/fs/hfsplus/hfsplus_fs.h~hfsplus-make-hfsplus_sync_fs-static +++ a/fs/hfsplus/hfsplus_fs.h @@ -428,7 +428,6 @@ int hfsplus_show_options(struct seq_file /* super.c */ struct inode *hfsplus_iget(struct super_block *, unsigned long); -int hfsplus_sync_fs(struct super_block *sb, int wait); /* tables.c */ extern u16 hfsplus_case_fold_table[]; diff -puN fs/hfsplus/super.c~hfsplus-make-hfsplus_sync_fs-static fs/hfsplus/super.c --- a/fs/hfsplus/super.c~hfsplus-make-hfsplus_sync_fs-static +++ a/fs/hfsplus/super.c @@ -161,7 +161,7 @@ static void hfsplus_evict_inode(struct i } } -int hfsplus_sync_fs(struct super_block *sb, int wait) +static int hfsplus_sync_fs(struct super_block *sb, int wait) { struct hfsplus_sb_info *sbi = HFSPLUS_SB(sb); struct hfsplus_vh *vhdr = sbi->s_vhdr; _ Subject: Subject: hfsplus: make hfsplus_sync_fs() static Patches currently in -mm which might be from artem.bityutskiy@xxxxxxxxxxxxxxx are linux-next.patch hfs-push-lock_super-down.patch hfs-get-rid-of-lock_super.patch hfs-remove-extra-mdb-write-on-unmount.patch hfs-simplify-a-bit-checking-for-r-o.patch hfs-introduce-vfs-superblock-object-back-reference.patch hfs-get-rid-of-hfs_sync_super.patch hfs-get-rid-of-hfs_sync_super-checkpatch-fixes.patch hfsplus-make-hfsplus_sync_fs-static.patch hfsplus-amend-debugging-print.patch hfsplus-remove-useless-check.patch hfsplus-get-rid-of-write_super.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html