The patch titled Subject: clk: validate pointer in __clk_disable() has been added to the -mm tree. Its filename is clk-validate-pointer-in-__clk_disable.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Fengguang Wu <fengguang.wu@xxxxxxxxx> Subject: clk: validate pointer in __clk_disable() clk_get() returns -ENOENT on error and some careless caller might dereference it without error checking: In mxc_rnga_remove(): struct clk *clk = clk_get(&pdev->dev, "rng"); // ... clk_disable(clk); Since it's insane to audit the lots of existing and future clk users, let's add a check in the callee to avoid kernel panic and warn about any buggy user. Cc: Russell King <rmk@xxxxxxxxxxxxxxxx> Cc: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> Cc: Viresh Kumar <viresh.kumar@xxxxxx> Cc: viresh kumar <viresh.linux@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/clk/clk.c | 3 +++ 1 file changed, 3 insertions(+) diff -puN drivers/clk/clk.c~clk-validate-pointer-in-__clk_disable drivers/clk/clk.c --- a/drivers/clk/clk.c~clk-validate-pointer-in-__clk_disable +++ a/drivers/clk/clk.c @@ -464,6 +464,9 @@ static void __clk_disable(struct clk *cl if (!clk) return; + if (WARN_ON(IS_ERR(clk))) + return; + if (WARN_ON(clk->enable_count == 0)) return; _ Subject: Subject: clk: validate pointer in __clk_disable() Patches currently in -mm which might be from fengguang.wu@xxxxxxxxx are origin.patch linux-next.patch clk-validate-pointer-in-__clk_disable.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html