The patch titled Subject: leds: lm3556: don't call kfree for the memory allocated by devm_kzalloc has been removed from the -mm tree. Its filename was leds-add-led-driver-for-lm3556-chip-fix.patch This patch was dropped because it was folded into leds-add-led-driver-for-lm3556-chip.patch The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ From: Axel Lin <axel.lin@xxxxxxxxx> Subject: leds: lm3556: don't call kfree for the memory allocated by devm_kzalloc The devm_* functions eliminate the need for manual resource releasing and simplify error handling. Resources allocated by devm_* are freed automatically on driver detach. Thus adding kfree calls here will introduce double free bug. Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx> Cc: Geon Si Jeong <gshark.jeong@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/leds/leds-lm3556.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff -puN drivers/leds/leds-lm3556.c~leds-add-led-driver-for-lm3556-chip-fix drivers/leds/leds-lm3556.c --- a/drivers/leds/leds-lm3556.c~leds-add-led-driver-for-lm3556-chip-fix +++ a/drivers/leds/leds-lm3556.c @@ -360,9 +360,8 @@ static int lm3556_probe(struct i2c_clien return -ENODATA; } - chip = - devm_kzalloc(&client->dev, sizeof(struct lm3556_chip_data), - GFP_KERNEL); + chip = devm_kzalloc(&client->dev, sizeof(struct lm3556_chip_data), + GFP_KERNEL); if (!chip) return -ENOMEM; @@ -416,7 +415,6 @@ err_create_torch_file: err_create_flash_file: err_chip_init: i2c_set_clientdata(client, NULL); - kfree(chip); return err; } @@ -430,7 +428,6 @@ static int lm3556_remove(struct i2c_clie led_classdev_unregister(&chip->cdev_flash); lm3556_write_reg(client, REG_ENABLE, 0); - kfree(chip); return 0; } _ Patches currently in -mm which might be from axel.lin@xxxxxxxxx are origin.patch linux-next.patch leds-add-led-driver-for-lm3556-chip.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html