The patch titled Subject: pipe: return -ENOIOCTLCMD instead of -EINVAL on unknown ioctl command has been added to the -mm tree. Its filename is pipe-return-enoioctlcmd-instead-of-einval-on-unknown-ioctl-command.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Will Deacon <will.deacon@xxxxxxx> Subject: pipe: return -ENOIOCTLCMD instead of -EINVAL on unknown ioctl command As described in commit 07d106d0a ("vfs: fix up ENOIOCTLCMD error handling"), drivers should return -ENOIOCTLCMD if they receive an ioctl command which they don't understand. Doing so will result in -ENOTTY being returned to userspace, which matches the behaviour of the compat layer if it fails to translate an ioctl command. This patch fixes the pipe ioctl to return -ENOIOCTLCMD instead of -EINVAL when passed an unknown ioctl command. Signed-off-by: Will Deacon <will.deacon@xxxxxxx> Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx> Acked-by: Alan Cox <alan@xxxxxxxxxxxxxxx> Cc: Jens Axboe <axboe@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN fs/pipe.c~pipe-return-enoioctlcmd-instead-of-einval-on-unknown-ioctl-command fs/pipe.c --- a/fs/pipe.c~pipe-return-enoioctlcmd-instead-of-einval-on-unknown-ioctl-command +++ a/fs/pipe.c @@ -693,7 +693,7 @@ static long pipe_ioctl(struct file *filp return put_user(count, (int __user *)arg); default: - return -EINVAL; + return -ENOIOCTLCMD; } } _ Subject: Subject: pipe: return -ENOIOCTLCMD instead of -EINVAL on unknown ioctl command Patches currently in -mm which might be from will.deacon@xxxxxxx are origin.patch linux-next.patch pipe-return-enoioctlcmd-instead-of-einval-on-unknown-ioctl-command.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html