The patch titled Subject: cciss: fix incorrect scsi status reporting has been added to the -mm tree. Its filename is cciss-fix-incorrect-scsi-status-reporting.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Stephen M. Cameron <scameron@xxxxxxxxxxxxxxxxxx> Subject: cciss: fix incorrect scsi status reporting Delete code which sets SCSI status incorrectly as it's already been set correctly above this incorrect code. Bug was introduced by b0e15f6db1110 ("cciss: fix typo that causes scsi status to be lost.") in 2009. Signed-off-by: Stephen M. Cameron <scameron@xxxxxxxxxxxxxxxxxx> Reported-by: Roel van Meer <roel.vanmeer@xxxxxxxxxx> Tested-by: Roel van Meer <roel.vanmeer@xxxxxxxxxx> Cc: Jens Axboe <axboe@xxxxxxxxx> Cc: <stable@xxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/block/cciss_scsi.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff -puN drivers/block/cciss_scsi.c~cciss-fix-incorrect-scsi-status-reporting drivers/block/cciss_scsi.c --- a/drivers/block/cciss_scsi.c~cciss-fix-incorrect-scsi-status-reporting +++ a/drivers/block/cciss_scsi.c @@ -763,16 +763,7 @@ static void complete_scsi_command(Comman { case CMD_TARGET_STATUS: /* Pass it up to the upper layers... */ - if( ei->ScsiStatus) - { -#if 0 - printk(KERN_WARNING "cciss: cmd %p " - "has SCSI Status = %x\n", - c, ei->ScsiStatus); -#endif - cmd->result |= (ei->ScsiStatus << 1); - } - else { /* scsi status is zero??? How??? */ + if (!ei->ScsiStatus) { /* Ordinarily, this case should never happen, but there is a bug in some released firmware revisions that allows it to happen _ Subject: Subject: cciss: fix incorrect scsi status reporting Patches currently in -mm which might be from scameron@xxxxxxxxxxxxxxxxxx are cciss-fix-incorrect-scsi-status-reporting.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html