The patch titled Subject: mm: fix off-by-one bug in print_nodes_state() has been added to the -mm tree. Its filename is mm-fix-off-by-one-bug-in-print_nodes_state.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Ryota Ozaki <ozaki.ryota@xxxxxxxxx> Subject: mm: fix off-by-one bug in print_nodes_state() /sys/devices/system/node/{online,possible} outputs a garbage byte because print_nodes_state() returns content size + 1. To fix the bug, the patch changes the use of cpuset_sprintf_cpulist to follow the use at other places, which is clearer and safer. This bug was introduced since v2.6.24 (bde631a51876f23e9). Signed-off-by: Ryota Ozaki <ozaki.ryota@xxxxxxxxx> Cc: Lee Schermerhorn <Lee.Schermerhorn@xxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/base/node.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff -puN drivers/base/node.c~mm-fix-off-by-one-bug-in-print_nodes_state drivers/base/node.c --- a/drivers/base/node.c~mm-fix-off-by-one-bug-in-print_nodes_state +++ a/drivers/base/node.c @@ -592,11 +592,9 @@ static ssize_t print_nodes_state(enum no { int n; - n = nodelist_scnprintf(buf, PAGE_SIZE, node_states[state]); - if (n > 0 && PAGE_SIZE > n + 1) { - *(buf + n++) = '\n'; - *(buf + n++) = '\0'; - } + n = nodelist_scnprintf(buf, PAGE_SIZE-2, node_states[state]); + buf[n++] = '\n'; + buf[n] = '\0'; return n; } _ Subject: Subject: mm: fix off-by-one bug in print_nodes_state() Patches currently in -mm which might be from ozaki.ryota@xxxxxxxxx are mm-fix-off-by-one-bug-in-print_nodes_state.patch lib-bitmapc-fix-documentation-for-scnprintf-functions.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html