The patch titled Subject: drivers/leds/leds-tca6507.c: cleanup error handling in tca6507_probe() has been removed from the -mm tree. Its filename was drivers-leds-leds-tca6507c-cleanup-error-handling-in-tca6507_probe.patch This patch was dropped because it was merged into mainline or a subsystem tree The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Subject: drivers/leds/leds-tca6507.c: cleanup error handling in tca6507_probe() Just a small tidy-up. 1) There is a NULL dereference if the tca allocation fails. 2) The call to cancel_work_sync() isn't needed because we haven't scheduled any work. 3) The call to i2c_set_clientdata() isn't needed because the core handles that automatically if probe() fails. 4) I added some curly braces for style reasons. Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Cc: Richard Purdie <rpurdie@xxxxxxxxx> Acked-by: NeilBrown <neilb@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/leds/leds-tca6507.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff -puN drivers/leds/leds-tca6507.c~drivers-leds-leds-tca6507c-cleanup-error-handling-in-tca6507_probe drivers/leds/leds-tca6507.c --- a/drivers/leds/leds-tca6507.c~drivers-leds-leds-tca6507c-cleanup-error-handling-in-tca6507_probe +++ a/drivers/leds/leds-tca6507.c @@ -687,10 +687,9 @@ static int __devinit tca6507_probe(struc NUM_LEDS); return -ENODEV; } - err = -ENOMEM; tca = kzalloc(sizeof(*tca), GFP_KERNEL); if (!tca) - goto exit; + return -ENOMEM; tca->client = client; INIT_WORK(&tca->work, tca6507_work); @@ -724,11 +723,10 @@ static int __devinit tca6507_probe(struc return 0; exit: - while (i--) + while (i--) { if (tca->leds[i].led_cdev.name) led_classdev_unregister(&tca->leds[i].led_cdev); - cancel_work_sync(&tca->work); - i2c_set_clientdata(client, NULL); + } kfree(tca); return err; } _ Patches currently in -mm which might be from dan.carpenter@xxxxxxxxxx are origin.patch linux-next.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html