The patch titled Subject: pps: class_create() returns an ERR_PTR, not NULL has been added to the -mm tree. Its filename is pps-class_create-returns-an-err_ptr-not-null.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Subject: pps: class_create() returns an ERR_PTR, not NULL class_create() never returns NULLs only ERR_PTRs. Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Cc: Rodolfo Giometti <giometti@xxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/pps/pps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/pps/pps.c~pps-checking-for-null-instead-of-is_err drivers/pps/pps.c --- a/drivers/pps/pps.c~pps-checking-for-null-instead-of-is_err +++ a/drivers/pps/pps.c @@ -369,9 +369,9 @@ static int __init pps_init(void) int err; pps_class = class_create(THIS_MODULE, "pps"); - if (!pps_class) { + if (IS_ERR(pps_class)) { pr_err("failed to allocate class\n"); - return -ENOMEM; + return PTR_ERR(pps_class); } pps_class->dev_attrs = pps_attrs; _ Subject: Subject: pps: class_create() returns an ERR_PTR, not NULL Patches currently in -mm which might be from dan.carpenter@xxxxxxxxxx are origin.patch linux-next.patch pps-class_create-returns-an-err_ptr-not-null.patch slab-introduce-kmalloc_array.patch mm-compaction-make-compact_control-order-signed.patch mm-compaction-make-compact_control-order-signed-fix.patch drivers-leds-leds-tca6507c-cleanup-error-handling-in-tca6507_probe.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html