The patch titled Subject: cs5535-clockevt: don't ignore MFGPT on SMP-capable kernels has been added to the -mm tree. Its filename is cs5535-clockevt-dont-ignore-mfgpt-on-smp-capable-kernels.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Jens Rottmann <JRottmann@xxxxxxxxxxxxxxxxxx> Subject: cs5535-clockevt: don't ignore MFGPT on SMP-capable kernels On SMP-capable kernels (e.g. generic distro kernel) the cs5535-clockevt driver loads but is not actually used. Setting cpumask to cpu_all_mask works for UP-only kernels, but if compiled for SMP - though still running on the same UP hardware - kernel/time/tick-common.c:tick_check_new_device() reads this as "non-cpu-local" and silently ignores the device. If we leave cpumask unset clockevents_register_device() will initialize it and the cs5535-clockevt driver will be used no matter how the kernel was compiled. Should anyone ever manage to stick a CS553x in an SMP system (is this even possible?) then a warning will be printed. This is fine as the cs5535-clockevt driver was never written/tested for SMP. If bisecting led you here this patch may have exposed a pre-existing MFGPT problem. Configure for UP-only and re-check. Signed-off-by: Jens Rottmann <JRottmann@xxxxxxxxxxxxxxxxxx> Acked-by: Andres Salomon <dilinger@xxxxxxxxxx> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> Cc: John Stultz <john.stultz@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/clocksource/cs5535-clockevt.c | 1 - 1 file changed, 1 deletion(-) diff -puN drivers/clocksource/cs5535-clockevt.c~cs5535-clockevt-dont-ignore-mfgpt-on-smp-capable-kernels drivers/clocksource/cs5535-clockevt.c --- a/drivers/clocksource/cs5535-clockevt.c~cs5535-clockevt-dont-ignore-mfgpt-on-smp-capable-kernels +++ a/drivers/clocksource/cs5535-clockevt.c @@ -100,7 +100,6 @@ static struct clock_event_device cs5535_ .set_mode = mfgpt_set_mode, .set_next_event = mfgpt_next_event, .rating = 250, - .cpumask = cpu_all_mask, .shift = 32 }; _ Subject: Subject: cs5535-clockevt: don't ignore MFGPT on SMP-capable kernels Patches currently in -mm which might be from JRottmann@xxxxxxxxxxxxxxxxxx are cs5535-clockevt-dont-ignore-mfgpt-on-smp-capable-kernels.patch cs5535-clockevt-allow-the-mfgpt-irq-to-be-shared.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html