The patch titled
Subject: crc32: remove two instances of trailing whitespaces
has been added to the -mm tree. Its filename is
crc32-removed-two-instances-of-trailing-whitespaces.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Bob Pearson <rpearson@xxxxxxxxxxxxxxxxxxxxx>
Subject: crc32: remove two instances of trailing whitespaces
This patchset (re)uses Bob Pearson's crc32 slice-by-8 code to stamp out a
software crc32c implementation. It removes the crc32c implementation in
crypto/ in favor of using the stamped-out one in lib/. There is also a
change to Kconfig so that the kernel builder can pick an implementation
best suited for the hardware.
The motivation for this patchset is that I am working on adding full
metadata checksumming to ext4. As far as performance impact of adding
checksumming goes, I see nearly no change with a standard mail server ffsb
simulation. On a test that involves only file creation and deletion and
extent tree writes, I see a drop of about 50 pcercent with the current
kernel crc32c implementation; this improves to a drop of about 20 percent
with the enclosed crc32c code.
When metadata is usually a small fraction of total IO, this new
implementation doesn't help much because metadata is usually a small
fraction of total IO. However, when we are doing IO that is almost all
metadata (such as rm -rf'ing a tree), then this patch speeds up the
operation substantially.
Incidentally, given that iscsi, sctp, and btrfs also use crc32c, this
patchset should improve their speed as well. I have not yet quantified
that, however. This latest submission combines Bob's patches from late
August 2011 with mine so that they can be one coherent patch set. Please
excuse my inability to combine some of the patches; I've been advised to
leave Bob's patches alone and build atop them instead. :/
Since the last posting, I've also collected some crc32c test results on a
bunch of different x86/powerpc/sparc platforms. The results can be viewed
here: http://goo.gl/sgt3i ; the "crc32-kern-le" and "crc32c" columns
describe the performance of the kernel's current crc32 and crc32c software
implementations. The "crc32c-by8-le" column shows crc32c performance with
this patchset applied. I expect crc32 performance to be roughly the same.
The two _boost columns at the right side of the spreadsheet shows how much
faster the new implementation is over the old one. As you can see, crc32
rises substantially, and crc32c experiences a huge increase.
This patch:
- remove trailing whitespace from lib/crc32.c
- remove trailing whitespace from lib/crc32defs.h
[djwong@xxxxxxxxxx: changelog tweaks]
Signed-off-by: Bob Pearson <rpearson@xxxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
lib/crc32.c | 2 +-
lib/crc32defs.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff -puN lib/crc32.c~crc32-removed-two-instances-of-trailing-whitespaces lib/crc32.c
--- a/lib/crc32.c~crc32-removed-two-instances-of-trailing-whitespaces
+++ a/lib/crc32.c
@@ -317,7 +317,7 @@ EXPORT_SYMBOL(crc32_be);
* in the correct multiple to subtract, we can shift a byte at a time.
* This produces a 40-bit (rather than a 33-bit) intermediate remainder,
* but again the multiple of the polynomial to subtract depends only on
- * the high bits, the high 8 bits in this case.
+ * the high bits, the high 8 bits in this case.
*
* The multiple we need in that case is the low 32 bits of a 40-bit
* value whose high 8 bits are given, and which is a multiple of the
diff -puN lib/crc32defs.h~crc32-removed-two-instances-of-trailing-whitespaces lib/crc32defs.h
--- a/lib/crc32defs.h~crc32-removed-two-instances-of-trailing-whitespaces
+++ a/lib/crc32defs.h
@@ -8,7 +8,7 @@
/* How many bits at a time to use. Requires a table of 4<<CRC_xx_BITS bytes. */
/* For less performance-sensitive, use 4 */
-#ifndef CRC_LE_BITS
+#ifndef CRC_LE_BITS
# define CRC_LE_BITS 8
#endif
#ifndef CRC_BE_BITS
_
Subject: Subject: crc32: remove two instances of trailing whitespaces
Patches currently in -mm which might be from rpearson@xxxxxxxxxxxxxxxxxxxxx are
origin.patch
crc32-removed-two-instances-of-trailing-whitespaces.patch
crc32-move-long-comment-about-crc32-fundamentals-to-documentation.patch
crc32-simplify-unit-test-code.patch
crc32-miscellaneous-cleanups.patch
crc32-fix-mixing-of-endian-specific-types.patch
crc32-make-crc__bits-definition-correspond-to-actual-bit-counts.patch
crc32-add-slice-by-8-algorithm-to-existing-code.patch
crc32-optimize-loop-counter-for-x86.patch
crc32-add-note-about-this-patchset-to-crc32c.patch
crc32-bolt-on-crc32c.patch
crypto-crc32c-should-use-library-implementation.patch
crc32-add-self-test-code-for-crc32c.patch
crc32-select-an-algorithm-via-kconfig.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
